Command interface for crux_time #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adwhit
reviewed
Jan 29, 2025
crux_time/src/command.rs
Outdated
| let (sender, mut receiver) = oneshot::channel(); | ||
|
|
||
| let builder = RequestBuilder::new(move |ctx| async move { | ||
| // We loop so that we can ignore the Err case of the oneshot receiver and still wait for the original request |
There was a problem hiding this comment.
What are the semantics here? If the sender is dropped, will the select! still block on the receiver (never resolving) or will the receiver immediately resolve to Err(_), causing a busy loop? The docs make it sound like the latter- https://docs.rs/futures/latest/futures/channel/oneshot/struct.Canceled.html
There was a problem hiding this comment.
From some testing I've done, dropping the Sender does not wake the future, so I think the Err branch of the cancel channel select is actually unreachable 🤔 I think it's because the Receiver is a FusedFuture and slect checks it's termination status.
Might change the code to remove the loop and put unreachable in there
StuartHarris
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this, I've revised how the cancellation works so that idea of IDs doesn't leak into the app.