Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ServerSentEvents capability in examples to command #305

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

StuartHarris
Copy link
Member

@StuartHarris StuartHarris commented Jan 24, 2025

Updates the ServerSentEvents capability in the counter example to use the new Command API.

Note that during the migration phase, this capability has to also be compatible with the old API so that #[derive(Effect)] can generate the relevant Effect enum variant. As we move past the migration, capabilities will become vanilla structs that have no special meaning in Crux and effectively just become Command generators. At this point we can simplify this capability, removing the CapabilityContext.

@StuartHarris StuartHarris marked this pull request as ready for review January 24, 2025 14:46
@StuartHarris StuartHarris requested a review from charypar January 25, 2025 12:35
@StuartHarris StuartHarris merged commit 7cbb961 into master Jan 27, 2025
9 checks passed
@StuartHarris StuartHarris deleted the sse-cap branch January 27, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants