Command support in Core #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StuartHarris
force-pushed
the
viktor/command
branch
from
d7e8dc6 to
212d7f5
Compare
StuartHarris
force-pushed
the
viktor/commands-in-core
branch
from
63ea5d6 to
1163b33
Compare
charypar
force-pushed
the
viktor/commands-in-core
branch
from
1163b33 to
bf4daf6
Compare
charypar
force-pushed
the
viktor/commands-in-core
branch
from
bf4daf6 to
40f8086
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the necessary changes to make Commands usable with
CoreandAppTester.It makes a fair few breaking changes to type signatures, but all quite mechanical and simple. I'll follow this up with a migration guide which people can follow.