Simplify construction of capabilities, so they don't require the app type #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StuartHarris
force-pushed
the
viktor/relax-effect-macro
branch
from
ab672b4 to
876f8da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was preventing having Apps with generic parameters, because the Effect derive macro would want the type name for the App.
Turns out that was down to the type definition of
WithContextwhich required theApptype, but doesn't strictly need to. It's job is to map capability's output to typeEffect(wrapping it).WithEffectcan now, strictly speaking, be implemented on anything, but we do restrict it down to being the App's capabilities type further up the chain inCore::new.A nice side effect (possibly independent?) is that
Core::newno longer needs to be generic. Sadly that also makes this a breaking change 😢