http encoding feature

[StuartHarris]

Nightly clippy reported that the crux_http crate was using the feature encoding, which wasn't declared in Cargo.toml. This fixes that. But we should agree that this is what we want to do.

Note that the decode_body function changes to use encoding_rs for non-wasm targets, and web-sys for wasm targets.

[obmarg]

But we should agree that this is what we want to do.

I wonder if it is. Looks like this feature allows you to use body_string with non-utf8 encodings. Which I suppose could be useful (although I can't think of a time I've ever needed that personally) - but I wonder if it's useful enough. I'd certainly be tempted to have it as an opt-in feature rather than a default, maybe even to ditch it altogether? Although not certain ditching it is the right move...

[obmarg]

Although having said that, maybe every server has been sending me utf-16 and I've just never noticed because of features like these. I don't know, maybe forget I spoke

[StuartHarris]

maybe forget I spoke

Haha! It looks to me like the implementation that uses encoding_rs could be better if it uses copy-on-write semantics, not sure.

[charypar]

@StuartHarris what do we wanna do about this then? 👀

[StuartHarris]

Since Rust 1.80.0 (out today) CI builds will fail with a warning that the encoding feature doesn't exist, so I'm going to merge this and we should update all open PRs from master.