-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix StorageClass filtering for add capacity modal #1049
fix StorageClass filtering for add capacity modal #1049
Conversation
/cherry-pick release-4.14 |
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.14-compatibility |
@SanjalKatiyar: once the present PR merges, I will cherry-pick it on top of release-4.14-compatibility in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@GowthamShanmugam PTAL. |
/test odf-console-e2e-aws |
packages/odf/utils/ocs.ts
Outdated
!sc | ||
? false | ||
: !OCS_PROVISIONERS.some((ocsProvisioner: string) => | ||
sc?.provisioner?.includes(ocsProvisioner) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!sc | |
? false | |
: !OCS_PROVISIONERS.some((ocsProvisioner: string) => | |
sc?.provisioner?.includes(ocsProvisioner) | |
); | |
!!sc && !OCS_PROVISIONERS.some((ocsProvisioner: string) => | |
sc?.provisioner?.includes(ocsProvisioner) | |
); |
735e1da
to
179bccf
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GowthamShanmugam, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4f5269c
into
red-hat-storage:master
@SanjalKatiyar: new pull request created: #1056 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@SanjalKatiyar: new pull request created: #1057 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2213183
Before:
After: