Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2210970: Support translation for ODF sub tab items #1015

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Bug 2210970: Support translation for ODF sub tab items #1015

merged 1 commit into from
Sep 19, 2023

Conversation

TimothyAsirJeyasing
Copy link
Contributor

@TimothyAsirJeyasing
Copy link
Contributor Author

@bipuladh Please review

SanjalKatiyar
SanjalKatiyar reviewed Aug 31, 2023
View reviewed changes
packages/odf/utils/horizontal-nav-tab.tsx Outdated
Comment on lines 13 to 19
// t('plugin__odf-console~Backing Store')
// t('plugin__odf-console~Object Storage')
// t('plugin__odf-console~Object Buckets')
// t('plugin__odf-console~Object Bucket Claims')
// t('plugin__odf-console~Namespace Store')
// t('plugin__odf-console~Bucket Class')
// t('plugin__odf-console~Topology')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// t('plugin__odf-console~Backing Store')
// t('plugin__odf-console~Object Storage')
// t('plugin__odf-console~Object Buckets')
// t('plugin__odf-console~Object Bucket Claims')
// t('plugin__odf-console~Namespace Store')
// t('plugin__odf-console~Bucket Class')
// t('plugin__odf-console~Topology')
// t('Backing Store')
// t('Object Storage')
// t('Object Buckets')
// t('Object Bucket Claims')
// t('Namespace Store')
// t('Bucket Class')
// t('Topology')

SanjalKatiyar
SanjalKatiyar reviewed Aug 31, 2023
View reviewed changes
packages/odf/utils/horizontal-nav-tab.tsx Outdated
Comment on lines 13 to 18
// t('plugin__odf-console~Backing Store')
// t('plugin__odf-console~Object Storage')
// t('plugin__odf-console~Object Buckets')
// t('plugin__odf-console~Object Bucket Claims')
// t('plugin__odf-console~Namespace Store')
// t('plugin__odf-console~Bucket Class')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add it in the file from where we are adding these horizontal navigations items...
/odf/components/object-service-nav-item/object-service.tsx

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add a comment on top for doing this...

SanjalKatiyar
SanjalKatiyar reviewed Aug 31, 2023
View reviewed changes
packages/odf/utils/horizontal-nav-tab.tsx Outdated
// t('plugin__odf-console~Object Bucket Claims')
// t('plugin__odf-console~Namespace Store')
// t('plugin__odf-console~Bucket Class')
// t('plugin__odf-console~Topology')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add it where we are adding this horizontal navigation item...
/odf/components/odf-dashboard/dashboard.tsx

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add a comment on top for doing this...

@SanjalKatiyar
Copy link
Collaborator

create a new file under /odf, name it i18n-comments.ts and move all the comments to that file at a single place...
also, add this comment on top of the file:

// This file adds comments recognized by the react-i18next-parser so that
// labels declared in console-extensions.json are added to the odf's translation namespace.

@SanjalKatiyar
Copy link
Collaborator

check why CI is failing...

@TimothyAsirJeyasing
Support translation for ODF sub tab items
0833cfc 
Signed-off-by: Timothy Asir Jeyasingh <[email protected]>
@SanjalKatiyar
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SanjalKatiyar, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6cd4948 into red-hat-storage:master Sep 19, 2023
3 checks passed
@SanjalKatiyar
Copy link
Collaborator

/retitle Bug 2210970: Support translation for ODF sub tab items

@openshift-ci openshift-ci bot changed the title Support translation for ODF sub tab items Bug 2210970: Support translation for ODF sub tab items Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanjalKatiyar SanjalKatiyar SanjalKatiyar left review comments

Assignees

@SanjalKatiyar SanjalKatiyar

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimothyAsirJeyasing @SanjalKatiyar @openshift-merge-robot