update the egress rules to allow loadBalancer IP on consumer side #289
Conversation
rewantsoni
force-pushed
the
egress
branch
2 times, most recently
from
86a7c3c to
17147b9
Compare
| if r.DeploymentType == consumerDeploymentType { | ||
|
|
||
| storageProviderEndpointURL := r.addonParams[storageProviderEndpointKey] | ||
| storageProviderEndpointHost := strings.Split(storageProviderEndpointURL, ":")[0] |
There was a problem hiding this comment.
This might panic if the split is yielding an empty array in the case of a malformed URL.
There was a problem hiding this comment.
Added a condition to return a error if the split is yielding an empty string
| if r.DeploymentType == consumerDeploymentType { | ||
|
|
||
| storageProviderEndpointURL := r.addonParams[storageProviderEndpointKey] | ||
| storageProviderEndpointHost := strings.Split(storageProviderEndpointURL, ":")[0] |
There was a problem hiding this comment.
This might panic if the split is yielding an empty array in the case of a malformed URL.
There was a problem hiding this comment.
Added a condition to return a error if the split is yielding an empty string
controllers/managedocs_controller.go
Outdated
| ip := net.ParseIP(storageProviderEndpointHost) | ||
|
|
||
| if ip == nil { |
There was a problem hiding this comment.
I think you wanted != and not ==.
Also, let's not pollute the func scope if we don't have to.
| ip := net.ParseIP(storageProviderEndpointHost) | |
| if ip == nil { | |
| if ip := net.ParseIP(storageProviderEndpointHost); ip == nil { |
There was a problem hiding this comment.
I want to check if the provided storageProviderEndpointHost is a nodeIP or a hostName, we want to allow the loadBalancer Endpoint HostName, we can ignore if we have nodeIP as it is already reachable.
controllers/managedocs_controller.go
Outdated
|
|
||
| ip := net.ParseIP(storageProviderEndpointHost) | ||
|
|
||
| if ip == nil { |
There was a problem hiding this comment.
I think you wanted != and not ==.
Also, let's not pollute the func scope if we don't have to.
| if ip == nil { | |
| if ip := net.ParseIP(storageProviderEndpointHost); ip == nil { |
There was a problem hiding this comment.
I want to check if the provided storageProviderEndpointHost is a nodeIP or a hostName, we want to allow the loadBalancer Endpoint HostName, we can ignore if we have nodeIP as it is already reachable.
Signed-off-by: Rewant Soni <[email protected]>
The consumer needs to access the loadbalancer IP, hence we need to put the rule in the allow list