Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rook csv rook/ceph:v1.5.0.737.g5478956 #1144

Closed
wants to merge 7 commits into from

Conversation

obnoxxx
Copy link
Contributor

@obnoxxx obnoxxx commented Apr 1, 2021

This is a spin-off of #1141 which aims at updating rook to the latest and greatest for both the csv and the go dependency. Because the go dependency implies more work around the codebase, this PR spins off just the csv part of the rook update.

@obnoxxx obnoxxx requested a review from jarrpa April 1, 2021 22:34
@obnoxxx obnoxxx removed the request for review from umangachapagain April 1, 2021 22:42
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2021
obnoxxx added 2 commits April 2, 2021 12:55
Latest image from upstream with crd inclusion fix

Signed-off-by: Michael Adam <[email protected]>
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2021
@obnoxxx
Copy link
Contributor Author

obnoxxx commented Apr 2, 2021

@jarrpa - this fails the same way as #1141...

@obnoxxx
Copy link
Contributor Author

obnoxxx commented Apr 2, 2021

/test ocs-operator-bundle-e2e-aws

@jarrpa
Copy link
Member

jarrpa commented Apr 2, 2021

/test verify-latest-csv

@jarrpa
Copy link
Member

jarrpa commented Apr 6, 2021

/test ocs-operator-bundle-e2e-aws

@jarrpa
Copy link
Member

jarrpa commented Apr 6, 2021

/retest

@jarrpa jarrpa force-pushed the update-rook-csv branch 2 times, most recently from 2f4b364 to 9186b81 Compare April 6, 2021 22:02
@jarrpa jarrpa force-pushed the update-rook-csv branch 2 times, most recently from 465145c to 110f017 Compare April 7, 2021 01:48
@jarrpa jarrpa force-pushed the update-rook-csv branch from 110f017 to acc11f6 Compare April 8, 2021 04:07
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 8, 2021

@obnoxxx: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/ocs-operator-ci acc11f6 link /test ocs-operator-ci
ci/prow/ocs-operator-bundle-e2e-aws acc11f6 link /test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@obnoxxx
Copy link
Contributor Author

obnoxxx commented Apr 9, 2021

superseded by #1150

@obnoxxx obnoxxx closed this Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants