Bug 2247737: add APIs to scheme, role and role binding to bundle #38

leelavg · 2023-11-02T11:25:05Z

Add missing ClusterVersion and ClusterServiceVersion APIs to status reporter Scheme
Add missing Role and RoleBinding to Kustomize and generate CSV Bundle

- ClusterVersion and ClusterServiceVersion APIs addition to scheme is missing in status reporter job Signed-off-by: Leela Venkaiah G <[email protected]>

- Status reporter role and role binding is missing in generated CSV bundle Signed-off-by: Leela Venkaiah G <[email protected]>

Madhu-1

changes LGTM, please let me know once testing is done

nb-ohad · 2023-11-02T14:24:41Z

LGTM

openshift-ci · 2023-11-03T05:37:39Z

@leelavg: This pull request references Bugzilla bug 2247737, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug

bug is open, matching expected state (open)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2247737: add APIs to scheme, role and role binding to bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-11-03T05:37:41Z

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@leelavg: This pull request references Bugzilla bug 2247737, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

2 validation(s) were run on this bug

bug is open, matching expected state (open)

bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Bug 2247737: add APIs to scheme, role and role binding to bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leelavg · 2023-11-03T05:44:47Z

Without fix:

$ k logs storageclient-abf16dbc3c286256-status-reporter-28316498-qj82x
W1103 05:39:24.428516       1 main.go:90] Failed to list csv resources: no kind is registered for the type v1alpha1.ClusterServiceVersionList in scheme "/remote-source/app/service/status-report/main.go:45"
W1103 05:39:24.428604       1 main.go:100] Unable to find csv with prefix "ocs-client-operator"
W1103 05:39:24.428613       1 main.go:107] Failed to get clusterVersion: no kind is registered for the type v1.ClusterVersion in scheme "/remote-source/app/service/status-report/main.go:45"
W1103 05:39:24.428620       1 main.go:117] Unable to find ocp version with completed update
F1103 05:39:24.438907       1 main.go:134] Failed to report status of storageClient 1cbb0e37-301b-427f-9b96-2161e4d48236: rpc error: code = InvalidArgument desc = Malformed ClientPlatformVersion: Version string empty

With fix:

$ cat storageclient-29011.yaml
apiVersion: batch/v1
kind: CronJob
metadata:
  name: storageclient-29011-status-reporter
  namespace: openshift-storage-client
spec:
  concurrencyPolicy: Allow
  failedJobsHistoryLimit: 1
  jobTemplate:
    metadata:
      creationTimestamp: null
    spec:
      template:
        metadata:
          creationTimestamp: null
        spec:
          containers:
          - command:
            - /status-reporter
            env:
            - name: STORAGE_CLIENT_NAMESPACE
              value: openshift-storage-client
            - name: STORAGE_CLIENT_NAME
              value: storageclient
            - name: OPERATOR_NAMESPACE
              value: openshift-storage-client
            image: quay.io/rhn_support_lgangava/code:29011
            imagePullPolicy: IfNotPresent
            name: heartbeat
          serviceAccount: ocs-client-operator-status-reporter
          serviceAccountName: ocs-client-operator-status-reporter
          terminationGracePeriodSeconds: 30
          restartPolicy: OnFailure
  schedule: '* * * * *'
  successfulJobsHistoryLimit: 3
  suspend: false
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
  creationTimestamp: null
  name: ocs-client-operator-status-reporter
  namespace: openshift-storage-client
rules:
- apiGroups:
  - operators.coreos.com
  resources:
  - clusterserviceversions
  verbs:
  - get
  - list
  - watch
---
kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
  name: ocs-client-operator-status-reporter
  namespace: openshift-storage-client
roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
  name: ocs-client-operator-status-reporter
subjects:
  - kind: ServiceAccount
    name: ocs-client-operator-status-reporter
    namespace: openshift-storage-client
---

$ k logs storageclient-29011-status-reporter-28316499-87v9d
[....EMPTY...]

$ k get storageconsumer storageconsumer-f4aec37d-d6de-4ea2-9d4c-4210170a4f92 -oyaml | yq 'del(.metadata.annotations)'
apiVersion: ocs.openshift.io/v1alpha1
kind: StorageConsumer
metadata:
  creationTimestamp: "2023-10-29T03:49:30Z"
  generation: 2
  name: storageconsumer-f4aec37d-d6de-4ea2-9d4c-4210170a4f92
  namespace: openshift-storage
  resourceVersion: "21003071"
  uid: 1cbb0e37-301b-427f-9b96-2161e4d48236
spec:
  enable: true
status:
  cephResources:
    - kind: CephClient
      name: 126102a1ddafcaa8045be5cfb98746c0
      status: Ready
  client:
    operatorVersion: 4.14.0-160.hci
    platformVersion: 4.14.0-rc.7
  lastHeartbeat: "2023-11-03T05:41:24Z"
  state: Ready

Madhu-1 · 2023-11-03T06:00:40Z

F1103 05:39:24.438907 1 main.go:134] Failed to report status of storageClient 1cbb0e37-301b-427f-9b96-2161e4d48236: rpc error: code = InvalidArgument desc = Malformed ClientPlatformVersion: Version string empty

@leelavg As we have multiple problems, Are we going to have a different PR for the above problem?

leelavg · 2023-11-03T06:07:46Z

F1103 05:39:24.438907 1 main.go:134] Failed to report status of storageClient 1cbb0e37-301b-427f-9b96-2161e4d48236: rpc error: code = InvalidArgument desc = Malformed ClientPlatformVersion: Version string empty

@leelavg As we have multiple problems, Are we going to have a different PR for the above problem?

this particular problem is kinda expected and it'll be fixed as part of BZ 2247743

nb-ohad · 2023-11-05T09:15:59Z

/lgtm

leelavg · 2023-11-06T04:28:29Z

@Madhu-1 if above testing isn't enough for the vote, I tested deploying via OLM

# date; ko logs ocs-provider-server-766fcb944d-d2t5g | grep 'consumer.go:226'
Monday 06 November 2023 09:57:18 AM IST
I1106 04:25:01.129650       1 consumer.go:226] successfully updated Status for StorageConsumer storageconsumer-b67a611e-3c50-4eb6-aa74-5c789aaf7b3c
I1106 04:26:01.071069       1 consumer.go:226] successfully updated Status for StorageConsumer storageconsumer-b67a611e-3c50-4eb6-aa74-5c789aaf7b3c
I1106 04:27:01.271745       1 consumer.go:226] successfully updated Status for StorageConsumer storageconsumer-b67a611e-3c50-4eb6-aa74-5c789aaf7b3c

Madhu-1 · 2023-11-06T05:20:54Z

/approved

Madhu-1 · 2023-11-06T05:21:19Z

/approve

Madhu-1 · 2023-11-06T05:22:57Z

/approve

Madhu-1 · 2023-11-06T05:24:24Z

/approve

Madhu-1 · 2023-11-06T05:24:55Z

/approve

openshift-ci · 2023-11-06T05:26:41Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: leelavg, Madhu-1, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Madhu-1 · 2023-11-06T05:27:09Z

/tide refresh

openshift-ci · 2023-11-06T05:29:42Z

@leelavg: All pull requests linked via external trackers have merged:

red-hat-storage/ocs-client-operator#38

Bugzilla bug 2247737 has been moved to the MODIFIED state.

In response to this:

Bug 2247737: add APIs to scheme, role and role binding to bundle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leelavg added 2 commits November 2, 2023 16:49

controllers: add APIs to status reporter scheme

0ccd859

- ClusterVersion and ClusterServiceVersion APIs addition to scheme is missing in status reporter job Signed-off-by: Leela Venkaiah G <[email protected]>

bundle: add status reporter role and role binding

45e7895

- Status reporter role and role binding is missing in generated CSV bundle Signed-off-by: Leela Venkaiah G <[email protected]>

pull-request-size bot added the size/S label Nov 2, 2023

Madhu-1 reviewed Nov 2, 2023

View reviewed changes

leelavg changed the title ~~add APIs to scheme, role and role binding to bundle~~ Bug 2247737: add APIs to scheme, role and role binding to bundle Nov 3, 2023

openshift-ci bot added bugzilla/severity-unspecified bugzilla/valid-bug labels Nov 3, 2023

openshift-ci bot assigned nb-ohad Nov 5, 2023

openshift-ci bot added the lgtm label Nov 5, 2023

Madhu-1 approved these changes Nov 6, 2023

View reviewed changes

openshift-ci bot assigned Madhu-1 Nov 6, 2023

Madhu-1 added the approved label Nov 6, 2023

openshift-ci bot removed the approved label Nov 6, 2023

Madhu-1 added the approved label Nov 6, 2023

Madhu-1 merged commit 1969a71 into red-hat-storage:fusion-hci-4.14 Nov 6, 2023
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 2247737: add APIs to scheme, role and role binding to bundle #38

Bug 2247737: add APIs to scheme, role and role binding to bundle #38

leelavg commented Nov 2, 2023 •

edited

Loading

Madhu-1 left a comment

nb-ohad commented Nov 2, 2023

openshift-ci bot commented Nov 3, 2023

openshift-ci bot commented Nov 3, 2023

leelavg commented Nov 3, 2023

Madhu-1 commented Nov 3, 2023

leelavg commented Nov 3, 2023

nb-ohad commented Nov 5, 2023

leelavg commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

openshift-ci bot commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

openshift-ci bot commented Nov 6, 2023

Bug 2247737: add APIs to scheme, role and role binding to bundle #38

Bug 2247737: add APIs to scheme, role and role binding to bundle #38

Conversation

leelavg commented Nov 2, 2023 • edited Loading

Madhu-1 left a comment

Choose a reason for hiding this comment

nb-ohad commented Nov 2, 2023

openshift-ci bot commented Nov 3, 2023

openshift-ci bot commented Nov 3, 2023

leelavg commented Nov 3, 2023

Madhu-1 commented Nov 3, 2023

leelavg commented Nov 3, 2023

nb-ohad commented Nov 5, 2023

leelavg commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

openshift-ci bot commented Nov 6, 2023

Madhu-1 commented Nov 6, 2023

openshift-ci bot commented Nov 6, 2023

leelavg commented Nov 2, 2023 •

edited

Loading