Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golang and ocs-operator dependency version #33

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Sep 27, 2023

  • Update golang and ocs-operator dependency version
  • Fix function signatures/usage for updated kube packages

@leelavg
Copy link
Contributor Author

leelavg commented Sep 27, 2023

Resolved/Disregard

Reason for the PR to be in Draft state:

CI Failures:

  • I'll relook at a later point of time as I see lint & build is passing for now locally
# date && go version && make lint build && date
Wednesday 27 September 2023 09:23:22 AM IST
go version go1.20.8 linux/amd64
docker run --rm -v /root/toolbox/orc/ocs-client-operator:/app:Z -w /app golangci/golangci-lint:v1.54.2 golangci-lint run ./...
level=warning msg="[runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
level=warning msg="[runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
level=warning msg="[runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused."
go mod tidy && go mod vendor
/root/toolbox/orc/ocs-client-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
docker build -t quay.io/ocs-dev/ocs-client-operator:latest .
[+] Building 230.8s (23/23) FINISHED                                                                                                             docker:default
 => [internal] load .dockerignore                                                                                                                          0.1s
 => => transferring context: 171B                                                                                                                          0.0s
 => [internal] load build definition from Dockerfile                                                                                                       0.1s
 => => transferring dockerfile: 921B                                                                                                                       0.0s
 => [internal] load metadata for gcr.io/distroless/static:nonroot                                                                                          0.0s
 => [internal] load metadata for docker.io/library/golang:1.20                                                                                             2.7s
 => [auth] library/golang:pull token for registry-1.docker.io                                                                                              0.0s
 => [builder  1/13] FROM docker.io/library/golang:1.20@sha256:6b29720c5598cb40b23dd38f522050a698d427c3a5696c5efe1ed22bd45b1396                             0.0s
 => CACHED [stage-1 1/4] FROM gcr.io/distroless/static:nonroot                                                                                             0.0s
 => [internal] load build context                                                                                                                          1.9s
 => => transferring context: 51.06MB                                                                                                                       1.9s
 => CACHED [builder  2/13] WORKDIR /workspace                                                                                                              0.0s
 => CACHED [builder  3/13] COPY go.mod go.sum ./                                                                                                           0.0s
 => CACHED [builder  4/13] COPY vendor/ vendor/                                                                                                            0.0s
 => CACHED [builder  5/13] COPY main.go Makefile ./                                                                                                        0.0s
 => [builder  6/13] COPY hack/ hack/                                                                                                                       1.1s
 => [builder  7/13] COPY api/ api/                                                                                                                         0.2s
 => [builder  8/13] COPY controllers/ controllers/                                                                                                         0.1s
 => [builder  9/13] COPY config/ config/                                                                                                                   0.2s
 => [builder 10/13] COPY pkg/ pkg/                                                                                                                         0.2s
 => [builder 11/13] COPY service/ service/                                                                                                                 0.1s
 => [builder 12/13] RUN make go-test                                                                                                                     101.0s
 => [builder 13/13] RUN make go-build                                                                                                                    120.4s
 => [stage-1 2/4] COPY --from=builder /workspace/bin/manager .                                                                                             0.1s
 => [stage-1 3/4] COPY --from=builder /workspace/bin/status-reporter .                                                                                     0.1s
 => exporting to image                                                                                                                                     1.1s
 => => exporting layers                                                                                                                                    1.0s
 => => writing image sha256:9fc90904914467c5f07c4b55ef41bb604c3ba8fec95c664a7900337429043c76                                                               0.0s
 => => naming to quay.io/ocs-dev/ocs-client-operator:latest                                                                                                0.0s
Wednesday 27 September 2023 09:29:23 AM IS

@leelavg leelavg force-pushed the csi-metrics-0-build branch from 074135f to e263826 Compare September 27, 2023 04:36
@leelavg leelavg force-pushed the csi-metrics-0-build branch from e263826 to 662f2c1 Compare October 4, 2023 07:02
@leelavg leelavg force-pushed the csi-metrics-0-build branch 3 times, most recently from 7f8da7f to 691410f Compare October 5, 2023 10:20
@leelavg leelavg marked this pull request as ready for review October 5, 2023 10:21
@leelavg leelavg requested review from Madhu-1 and nb-ohad October 5, 2023 10:24
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@leelavg leelavg force-pushed the csi-metrics-0-build branch from 691410f to 2257b65 Compare October 6, 2023 02:45
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, @leelavg any specific reason to get this merged to the custom 4.14 branch, I would suggest getting this merged to main branch and backport it to the custom branch.

@leelavg
Copy link
Contributor Author

leelavg commented Oct 6, 2023

I was asked (by Ohad) to have every commit for hci effort across all the repos that we touch to this custom branch and build team would use that branch.

@nb-ohad
Copy link
Contributor

nb-ohad commented Oct 23, 2023

@Madhu-1 All of the changes in the HCI branch are to be merged with the 4.14 branch after we get it released to target the next z stream of 4.14. Then we are planning to cherry pick all of it on top of main branch.

@leelavg leelavg changed the title Pin Kube API dependencies and update golang version update golang and ocs-operator dependency version Oct 23, 2023
@nb-ohad
Copy link
Contributor

nb-ohad commented Oct 24, 2023

/lgtm

@Madhu-1
Copy link
Member

Madhu-1 commented Oct 24, 2023

/approve

1 similar comment
@Madhu-1
Copy link
Member

Madhu-1 commented Oct 25, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leelavg, Madhu-1, nb-ohad

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Madhu-1 Madhu-1 merged commit 261ebf3 into red-hat-storage:fusion-hci-4.14 Oct 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants