-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update golang and ocs-operator dependency version #33
update golang and ocs-operator dependency version #33
Conversation
leelavg
commented
Sep 27, 2023
•
edited
Loading
edited
- Update golang and ocs-operator dependency version
- Fix function signatures/usage for updated kube packages
Resolved/DisregardReason for the PR to be in Draft state:
CI Failures:
|
074135f
to
e263826
Compare
e263826
to
662f2c1
Compare
7f8da7f
to
691410f
Compare
Signed-off-by: Leela Venkaiah G <[email protected]>
Signed-off-by: Leela Venkaiah G <[email protected]>
691410f
to
2257b65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM, @leelavg any specific reason to get this merged to the custom 4.14 branch, I would suggest getting this merged to main branch and backport it to the custom branch.
I was asked (by Ohad) to have every commit for hci effort across all the repos that we touch to this custom branch and build team would use that branch. |
@Madhu-1 All of the changes in the HCI branch are to be merged with the 4.14 branch after we get it released to target the next z stream of 4.14. Then we are planning to cherry pick all of it on top of main branch. |
/lgtm |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leelavg, Madhu-1, nb-ohad The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |