Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFBUGS-963: [release-4.18] controllers: fix predicate to trigger reconcile for mmode controller #291

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #288

/assign openshift-ci-robot

trigger reconcile of mmode controller when the storageClient's
status is updated

Signed-off-by: Rewant Soni <[email protected]>
@rewantsoni
Copy link
Member

rewantsoni commented Dec 4, 2024

/retitle DFBUGS-963: [release-4.18] controllers: fix predicate to trigger reconcile for mmode controller

@openshift-ci openshift-ci bot changed the title [release-4.18] controllers: fix predicate to trigger reconcile for mmode controller DFBUGS-963: [release-4.18] controllers: fix predicate to trigger reconcile for mmode controller Dec 4, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type labels Dec 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2024

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-963](https://issues.redhat.com//browse/DFBUGS-963), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

This is an automated cherry-pick of #288

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Dec 4, 2024
@leelavg
Copy link
Contributor

leelavg commented Dec 4, 2024

/lgtm

Copy link

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8b37047 into red-hat-storage:release-4.18 Dec 4, 2024
11 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2024

@openshift-cherrypick-robot: [Jira Issue DFBUGS-963](https://issues.redhat.com//browse/DFBUGS-963): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-963](https://issues.redhat.com//browse/DFBUGS-963) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #288

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants