Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from main for ocs-client-operator #279

Merged
merged 8 commits into from
Nov 23, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from main branch

rewantsoni and others added 8 commits November 20, 2024 22:09
Signed-off-by: Rewant Soni <[email protected]>
controllers: create vrc sent by the provider
controllers: add missing owner on sc and vsc
controllers: set the vrc name to what we get from provider
@df-build-team df-build-team requested a review from a team November 22, 2024 16:08
@leelavg
Copy link
Contributor

leelavg commented Nov 23, 2024

/lgtm
/hold

@rewantsoni unhold when ocs-op vrc pr is synced to 4.18

@rewantsoni
Copy link
Member

/unhold

@rewantsoni
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Nov 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, leelavg, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b1babc6 into release-4.18 Nov 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants