Push the smallfile test results into elasticsearch server. #1984

Avilir · 2020-05-03T16:35:12Z

Results push via ripsaw (snafu) and also with some more information
directly by this test.
Also, increas the number of the samples from 1 to 3.

Signed-off-by: Avi liani [email protected]

Also, it will retrieve the previous test results and compare to current result to see if there is a regression / progression or no change.

Results push via ripsaw (snafu) and also with some more information directly by this test. Also, increas the number of the samples from 1 to 3. Signed-off-by: Avi liani <[email protected]>

Signed-off-by: Avi liani <[email protected]>

ocs_ci/ocs/cluster.py

keesturam

Looks great @Avilir

tests/e2e/performance/test_small_file_workload.py

Signed-off-by: Avi liani <[email protected]>

Remove one test from the suit. Signed-off-by: Avi liani <[email protected]>

ocs_ci/ocs/ocp.py

Signed-off-by: Avi liani <[email protected]>

ocs_ci/ocs/cluster.py

ocs_ci/ocs/ocp.py

ocs_ci/templates/workloads/smallfile/SmallFile.yaml

tests/e2e/performance/test_small_file_workload.py

@ebenahar

as per @ebenahar suggestion. Signed-off-by: Avi liani <[email protected]>

Signed-off-by: Avi liani <[email protected]>

…name of the get_ocp_version to get_ocs_version Signed-off-by: Avi liani <[email protected]>

Signed-off-by: Avi liani <[email protected]>

tests/e2e/performance/test_small_file_workload.py

vasukulkarni · 2020-05-11T16:02:21Z

Can you schedule a test run in AWS for this test?

ocs_ci/ocs/ocp.py

keesturam · 2020-05-12T04:03:16Z

@Avilir Looks great, Would it be possible to attach the log of sample test run?

Signed-off-by: Avi liani <[email protected]>

…es deviation Signed-off-by: Avi liani <[email protected]>

Signed-off-by: Avi liani <[email protected]>

Avilir · 2020-05-12T12:40:09Z

@Avilir Looks great, Would it be possible to attach the log of sample test run?

@keesturam

You can find sample results at : here
as you can see the test Failed since in lines 179, 183 and 187 it report on "Error : Deviation < > IOPS is more the 5% ()"

will try to trigger Jenkins job (which probably will fails too)

ocs-ci

PR validation Job FAILED (installation failed, tests not executed).

ocs_ci/ocs/ocp.py

tests/e2e/performance/test_small_file_workload.py

fbalak

LGTM, just some docstring suggestions

tests/e2e/performance/test_small_file_workload.py

Signed-off-by: Avi liani <[email protected]>

tests/e2e/performance/test_small_file_workload.py

…torage#1984) * Push the smallfile test results into elasticsearch server. Results push via ripsaw (snafu) and also with some more information directly by this test. Also, increas the number of the samples from 1 to 3. Signed-off-by: Avi liani <[email protected]>

Push the smallfile test results into elasticsearch server.

32f2c7e

Results push via ripsaw (snafu) and also with some more information directly by this test. Also, increas the number of the samples from 1 to 3. Signed-off-by: Avi liani <[email protected]>

Avilir requested a review from a team as a code owner May 3, 2020 16:35

pull-request-size bot added the size/L PR that changes 100-499 lines label May 3, 2020

Adding the elasticsearch module to the requirements.txt

f2e4acd

Signed-off-by: Avi liani <[email protected]>

AviadP reviewed May 3, 2020

View reviewed changes

ocs_ci/ocs/cluster.py Outdated Show resolved Hide resolved

AviadP reviewed May 3, 2020

View reviewed changes

ocs_ci/ocs/cluster.py Outdated Show resolved Hide resolved

AviadP reviewed May 3, 2020

View reviewed changes

ocs_ci/ocs/cluster.py Outdated Show resolved Hide resolved

keesturam reviewed May 4, 2020

View reviewed changes

tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved

tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved

Avilir added 2 commits May 4, 2020 09:18

using ocp.get() instead of run_cmd()

f0470bc

Signed-off-by: Avi liani <[email protected]>

Fix typo in name of function.

b7dc92c

Remove one test from the suit. Signed-off-by: Avi liani <[email protected]>

AviadP reviewed May 4, 2020

View reviewed changes

ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved

Replace run_cmd commands with ocp.get

291f966

Signed-off-by: Avi liani <[email protected]>

ebenahar reviewed May 4, 2020

View reviewed changes

Avilir added 7 commits May 4, 2020 18:31

Moving OCP related functions from cluster.py to ocp.py

5c28969

as per @ebenahar suggestion. Signed-off-by: Avi liani <[email protected]>

Cleanup of docstings

7825cf7

Signed-off-by: Avi liani <[email protected]>

delete empty line - for flake8 compatability

e01bcb8

Signed-off-by: Avi liani <[email protected]>

Taking rhe get_ocp_provider function out of the class and change the …

8e80979

…name of the get_ocp_version to get_ocs_version Signed-off-by: Avi liani <[email protected]>

Updating the smallfile yaml template file

9aedc5d

Signed-off-by: Avi liani <[email protected]>

Adding numpy to the requirements.txt

7fd00ea

Signed-off-by: Avi liani <[email protected]>

Replacing the test analysing with object to analyse results

31b5769

Signed-off-by: Avi liani <[email protected]>

Avilir changed the title ~~[WIP] Push the smallfile test results into elasticsearch server.~~ Push the smallfile test results into elasticsearch server. May 11, 2020

vasukulkarni reviewed May 11, 2020

View reviewed changes

tests/e2e/performance/test_small_file_workload.py Show resolved Hide resolved

vasukulkarni reviewed May 11, 2020

View reviewed changes

ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved

vasukulkarni reviewed May 11, 2020

View reviewed changes

ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved

vasukulkarni reviewed May 11, 2020

View reviewed changes

ocs_ci/ocs/ocp.py Outdated Show resolved Hide resolved

Avilir added 3 commits May 12, 2020 11:45

Change functions name (remove ocp from the name)

e6eba44

Signed-off-by: Avi liani <[email protected]>

Adding UUID to full results output, Changing the calculation of sampl…

fc03477

…es deviation Signed-off-by: Avi liani <[email protected]>

fix merge problem

6f0f949

Signed-off-by: Avi liani <[email protected]>

Avilir requested review from ebenahar, keesturam and vasukulkarni May 12, 2020 13:10

ocs-ci reviewed May 12, 2020

View reviewed changes

vasukulkarni mentioned this pull request May 12, 2020

Need a mark to skip test on AWS platform #2049

Closed

vasukulkarni previously approved these changes May 12, 2020

View reviewed changes

ebenahar reviewed May 14, 2020

View reviewed changes

fbalak reviewed May 14, 2020

View reviewed changes

Avilir added 2 commits May 14, 2020 16:13

Fixing some doc strings

953c854

Signed-off-by: Avi liani <[email protected]>

Adding doc string

2e4227a

Signed-off-by: Avi liani <[email protected]>

Avilir dismissed vasukulkarni’s stale review via 2e4227a May 14, 2020 13:15

Avilir added 2 commits May 14, 2020 16:19

fixing the way of command writting

007c177

Signed-off-by: Avi liani <[email protected]>

Moved the get_provider() function from ocp to node module

f978509

Signed-off-by: Avi liani <[email protected]>

Avilir requested review from fbalak, ebenahar and vasukulkarni May 14, 2020 13:52

fbalak approved these changes May 14, 2020

View reviewed changes

tests/e2e/performance/test_small_file_workload.py Show resolved Hide resolved

ebenahar approved these changes May 14, 2020

View reviewed changes

bengland2 reviewed May 14, 2020

View reviewed changes

tests/e2e/performance/test_small_file_workload.py Outdated Show resolved Hide resolved

vasukulkarni approved these changes May 14, 2020

View reviewed changes

vasukulkarni merged commit 7958eb8 into red-hat-storage:master May 14, 2020

keesturam added the performance label May 18, 2020

bengland2 mentioned this pull request May 19, 2020

[FIO]: Elasticsearch index 'ripsaw-fio-analyzed-result' doesn't record the std-deviation for randomread and randomwrite cloud-bulldozer/benchmark-wrapper#180

Open

keesturam mentioned this pull request May 21, 2020

'test_smallfile_workload' fails trying to collect 'git config --get user.name' #2137

Closed

Avilir deleted the smallfiles-compar branch December 8, 2021 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Push the smallfile test results into elasticsearch server. #1984

Push the smallfile test results into elasticsearch server. #1984

Avilir commented May 3, 2020

keesturam left a comment

vasukulkarni commented May 11, 2020

keesturam commented May 12, 2020

Avilir commented May 12, 2020 •

edited

Loading

ocs-ci left a comment

fbalak left a comment

Push the smallfile test results into elasticsearch server. #1984

Push the smallfile test results into elasticsearch server. #1984

Conversation

Avilir commented May 3, 2020

keesturam left a comment

Choose a reason for hiding this comment

vasukulkarni commented May 11, 2020

keesturam commented May 12, 2020

Avilir commented May 12, 2020 • edited Loading

ocs-ci left a comment

Choose a reason for hiding this comment

fbalak left a comment

Choose a reason for hiding this comment

Avilir commented May 12, 2020 •

edited

Loading