feat: adds status information to the LVMCluster CR #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sp98
suggested changes
Jan 18, 2022
api/v1alpha1/lvmcluster_types.go
Outdated
| DeviceClassStatuses []DeviceClassStatus `json:"deviceClassStatuses,omitempty"` | ||
| } | ||
|
|
||
| // VGNodeStatus defines the observed status of the VG across all nodes |
There was a problem hiding this comment.
Suggested change
| // VGNodeStatus defines the observed status of the VG across all nodes | |
| // DeviceClassStatus defines the observed status of the VG across all nodes |
api/v1alpha1/lvmcluster_types.go
Outdated
|
|
||
| // VGNodeStatus defines the observed status of the VG across all nodes | ||
| type DeviceClassStatus struct { | ||
| // Name is the name of the VG |
There was a problem hiding this comment.
This might cause confusion between VG and DeviceClass. I think we should use either VG or DeviceClass
api/v1alpha1/lvmcluster_types.go
Outdated
| type DeviceClassStatus struct { | ||
| // Name is the name of the VG | ||
| Name string `json:"name,omitempty"` | ||
| // Status tells if the VG was created on the node |
There was a problem hiding this comment.
Suggested change
| // Status tells if the VG was created on the node | |
| // NodeStatus tells if the VG was created on the node |
controllers/lvmcluster_controller.go
Outdated
| @@ -197,6 +197,53 @@ func (r *LVMClusterReconciler) reconcile(ctx context.Context, instance *lvmv1alp | |||
| return ctrl.Result{}, nil | |||
| } | |||
|
|
|||
| func (r *LVMClusterReconciler) updateLVMClusterStatus(ctx context.Context, instance *lvmv1alpha1.LVMCluster) error { | |||
|
|
|||
| vgnodemap := make(map[string][]lvmv1alpha1.NodeStatus) | |||
There was a problem hiding this comment.
Suggested change
| vgnodemap := make(map[string][]lvmv1alpha1.NodeStatus) | |
| vgNodeMap := make(map[string][]lvmv1alpha1.NodeStatus) |
controllers/lvmcluster_controller.go
Outdated
| return err | ||
| } | ||
|
|
||
| for _, nodeitem := range vgNodeStatusList.Items { |
There was a problem hiding this comment.
Suggested change
| for _, nodeitem := range vgNodeStatusList.Items { | |
| for _, nodeItem := range vgNodeStatusList.Items { |
The LVMCluster.Status will now contain a list of VGs, the nodes on which they have been created and the status on that node. Signed-off-by: N Balachandran <[email protected]>
The LVMCluster controller will update the LVMCluster.Status with the consolidated status information in the LVMVolumeGroupNodeStatus objects. Signed-off-by: N Balachandran <[email protected]>
sp98
approved these changes
Jan 18, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leelavg, nbalacha, sp98 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LVMCluster operator will now consolidate the information in the LVMVolumeGroupNodeStatus objects and update the LVMCluster.Status.