LVMCluster CRD changes #115
Conversation
This change introduces a storage field in the LVMCluster CRD which contains the deviceClasses. This commit contains the API changes and manifests. Signed-off-by: N Balachandran <[email protected]>
Code changes to use the updated LVMCluster definition. Signed-off-by: N Balachandran <[email protected]>
The tests have been updated to use the updated LVMCluster CRD definition. Signed-off-by: N Balachandran <[email protected]>
openshift-ci
bot
added
the
approved
nbalacha
requested review from
leelavg and
sp98
and removed request for
leelavg
| @@ -31,9 +31,9 @@ type LVMClusterSpec struct { | |||
| // Tolerations to apply to nodes to act on | |||
| // +optional | |||
| Tolerations []corev1.Toleration `json:"tolerations,omitempty"` | |||
| // DeviceClasses are a rules that assign local storage devices to volumegroups that are used for creating lvm based PVs | |||
| // Storage describes the deviceClass configuration for local storage devices | |||
There was a problem hiding this comment.
To keep it future-ready, should we update the description of the Storage field to be more generic or less aligned with DeviceClass; Thoughts?
There was a problem hiding this comment.
A good point. How about "Storage describes the configuration for local storage devices" ?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, nbalacha, sp98 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.10 |
|
@nbalacha: new pull request created: #117 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The LVMCluster.Spec has been updated to add a "storage" field which will contain storage related configuration.