-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2049081: reclaimspace: do not report Unimplemented as an error #26
Bug 2049081: reclaimspace: do not report Unimplemented as an error #26
Conversation
When a CSI-driver does not implement NodeReclaimSpace and/or ControllerReclaimSpace, it should not reported as an error. Signed-off-by: Niels de Vos <[email protected]> (cherry picked from commit 113628d)
@nixpanic: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nixpanic: This pull request references Bugzilla bug 2049081, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@nixpanic do we have all the required acks in BZ. Making sure before approving it. |
looks like we have all acks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, nixpanic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nixpanic: All pull requests linked via external trackers have merged: Bugzilla bug 2049081 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When a CSI-driver does not implement NodeReclaimSpace and/or
ControllerReclaimSpace, it should not reported as an error.
(cherry picked from commit 113628d, part of #25)