Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2049081: reclaimspace: do not report Unimplemented as an error #26

Merged

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Feb 3, 2022

When a CSI-driver does not implement NodeReclaimSpace and/or
ControllerReclaimSpace, it should not reported as an error.

(cherry picked from commit 113628d, part of #25)

When a CSI-driver does not implement NodeReclaimSpace and/or
ControllerReclaimSpace, it should not reported as an error.

Signed-off-by: Niels de Vos <[email protected]>
(cherry picked from commit 113628d)
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

@nixpanic: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[Bug 2049081] reclaimspace: do not report Unimplemented as an error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved label Feb 3, 2022
@nixpanic nixpanic changed the title [Bug 2049081] reclaimspace: do not report Unimplemented as an error Bug 2049081: reclaimspace: do not report Unimplemented as an error Feb 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

@nixpanic: This pull request references Bugzilla bug 2049081, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @ebenahar

In response to this:

Bug 2049081: reclaimspace: do not report Unimplemented as an error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 3, 2022

@nixpanic do we have all the required acks in BZ. Making sure before approving it.

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 3, 2022

looks like we have all acks
/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ccdf22d into red-hat-storage:release-4.10 Feb 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2022

@nixpanic: All pull requests linked via external trackers have merged:

Bugzilla bug 2049081 has been moved to the MODIFIED state.

In response to this:

Bug 2049081: reclaimspace: do not report Unimplemented as an error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic nixpanic deleted the ds/bz/2049081 branch February 3, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants