Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

[BUG] Real time notifications not work (as in live example greensocial.herokuapp.com) #30

Closed
sevastosm opened this issue Oct 26, 2017 · 2 comments

Comments

@sevastosm
Copy link

Steps

1 Running the app on my local machine
2 Opening two different browsers ,
3 Log in with a differed user account on each browser

Expected Result

If a user votes a post the account in that posted must get a notification in the broswer.

Actual Result

I have to refresh the page to get notification from other folowers

Version

x.y.z

Testcase

@sevastosm sevastosm changed the title Real time notifications not work [BUG] Real time notifications not work (as in live example greensocial.herokuapp.com) Oct 26, 2017
@Qolzam Qolzam added the bug label Oct 26, 2017
Qolzam added a commit that referenced this issue Oct 26, 2017
@Qolzam
Copy link
Member

Qolzam commented Oct 26, 2017

Thank you for reporting 👍 . Moving getNotifications to the service layer and return promise from on() observable method of firebase can't call resolve() method for the next change. I used a callback function to solve it but following project principles it is anti pattern. So I let it open to find a better way.

@Qolzam
Copy link
Member

Qolzam commented Mar 24, 2018

Solved by implementing redux-saga channel here #48 .

@Qolzam Qolzam closed this as completed Mar 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants