Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "wikipedia-kyoto-japanese-english: increase REXML entity expansion limit during XML parsing (#198) #201

Conversation

otegami
Copy link
Member

@otegami otegami commented Aug 24, 2024

This reverts commit a76b917.

REXML has fixed the bug where REXML::Security.entity_expansion_text_limit incorrectly calculated text size in both SAX and pull parsers. Therefore, we no longer need to handle this issue within Red Datasets.

ref: https://github.com/ruby/rexml/releases/tag/v3.3.5

…sion limit during XML parsing (red-data-tools#198)"

This reverts commit a76b917.

REXML has fixed the bug where `REXML::Security.entity_expansion_text_limit`
incorrectly calculated text size in both SAX and pull parsers.
Therefore, we no longer need to handle this issue within Red Datasets.

ref: https://github.com/ruby/rexml/releases/tag/v3.3.5
@kou kou merged commit e3691b9 into red-data-tools:master Aug 24, 2024
0 of 12 checks passed
@otegami otegami deleted the revert-increase-rexml-entity-expansion-limit branch August 24, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants