Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RiskDataCollector component #61

Merged
merged 2 commits into from
May 1, 2020
Merged

Adds RiskDataCollector component #61

merged 2 commits into from
May 1, 2020

Conversation

chrissrogers
Copy link
Member

@chrissrogers chrissrogers commented Apr 30, 2020

import { RiskDataCollector } from '@recurly/react-recurly';

() => {
  const handleError = (error) => {
    // error.code
    // error.message
  };

  return (
    <RiskDataCollector
      strategy="kount"
      onError={handleError}
    />
  );
};

@guardrails
Copy link

guardrails bot commented Apr 30, 2020

⚠️ We detected security issues in this pull request:

Vulnerable Libraries (1)
  • [email protected] upgrade to >=6.0.4 <6.1.0 || >=6.1.2 <6.2.0 || >=6.2.3 <6.3.0 || >=6.3.2

More info on how to fix Vulnerable Libraries in Javascript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build e7ea1e8ec304a2e7869cffd9db3e7dd981e369dc-PR-61

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 98.182%

Totals Coverage Status
Change from base Build c126874d73ed89c46089df3cf6b7170b8f39cffb: 0.1%
Covered Lines: 215
Relevant Lines: 216

💛 - Coveralls

@chrissrogers
Copy link
Member Author

Just noting that this is mergeable. Guardrails is blocking, but we can't clear that dev dependency cleanly until koa-qs updates get picked up koajs/qs#25

The top PRs on that lib are all dep bumps: https://github.com/koajs/qs/pulls

@@ -244,6 +245,12 @@ function TestComponent() {
<CardYearElement {...elementProps} />
<CardCvvElement {...elementProps} />
</Elements>
<RiskDataCollector
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dope

@chrissrogers chrissrogers force-pushed the risk-data-collector branch from 09e8533 to 7f9db19 Compare May 1, 2020 18:00
Copy link
Contributor

@dbrudner dbrudner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dbrudner dbrudner merged commit 2a9baa3 into master May 1, 2020
@dbrudner dbrudner deleted the risk-data-collector branch May 1, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants