Adds small changes to useCheckoutPricing test suite #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 29f2b31510471e90151dcc6d52f3832afa89183e-PR-35
💛 - Coveralls |
dbrudner
commented
Mar 3, 2020
| @@ -153,16 +151,6 @@ describe('useCheckoutPricing', function() { | |||
| }); | |||
|
|
|||
| describe('adjustments', () => { | |||
| it('should call checkoutPricing.adjustment for each adjustment', async () => { | |||
There was a problem hiding this comment.
This test is nearly identical to the one below it and was removed for being redundant.
dbrudner
commented
Mar 3, 2020
| @@ -222,19 +210,6 @@ describe('useCheckoutPricing', function() { | |||
| describe('Error handler', () => { | |||
| it('should be passed to .catch', async () => { | |||
| const handleError = jest.fn(); | |||
| window.Promise.all = function() { | |||
There was a problem hiding this comment.
This is completely unnecessary, I'm not sure why I tried mocking this out in the first place.
I think it had to do with having difficulty with getting this test to pass. For some reason, the waitForNextUpdate utility wasn't waiting long enough before checkoutPricing.catch was being called, hence the usage of setTimeout.
I'd love to remove the setTimeout in favor of something more consistent, but wasn't able to find a way to do this.
chrissrogers
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.