setup element when didmount #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 846
💛 - Coveralls |
chrissrogers
approved these changes
Oct 25, 2022
recurly-integrations
pushed a commit
that referenced
this pull request
Oct 27, 2022
[Full Changelog](v1.2.4...v1.2.5) **Merged Pull Requests** - listen_for_attach_event [#187](#187) ([smagdicatrecurly](https://github.com/smagdicatrecurly)) - Adds demo for automated focus shift on individual card Elements [#183](#183) ([chrissrogers](https://github.com/chrissrogers)) - setup element when didmount [#182](#182) ([WillXing](https://github.com/WillXing)) - Docs fix: UseCheckoutPricingInput `subscriptions` [#157](#157) ([javimbk](https://github.com/javimbk)) - Docs Fix: useRecurly Paypal example [#156](#156) ([javimbk](https://github.com/javimbk)) - Revert "add security to github CODEOWNER file" [#147](#147) ([eternal44](https://github.com/eternal44)) - add security to github CODEOWNER file [#142](#142) ([eternal44](https://github.com/eternal44)) - fix(lib/provider.js): fix RecurlyProvider throwing error when fraud property is set [#123](#123) ([mikeedwards](https://github.com/mikeedwards))
recurly-integrations
pushed a commit
that referenced
this pull request
Oct 27, 2022
[Full Changelog](v1.2.4...v1.2.6) **Merged Pull Requests** - listen_for_attach_event [#187](#187) ([smagdicatrecurly](https://github.com/smagdicatrecurly)) - Adds demo for automated focus shift on individual card Elements [#183](#183) ([chrissrogers](https://github.com/chrissrogers)) - setup element when didmount [#182](#182) ([WillXing](https://github.com/WillXing)) - Docs fix: UseCheckoutPricingInput `subscriptions` [#157](#157) ([javimbk](https://github.com/javimbk)) - Docs Fix: useRecurly Paypal example [#156](#156) ([javimbk](https://github.com/javimbk)) - Revert "add security to github CODEOWNER file" [#147](#147) ([eternal44](https://github.com/eternal44)) - add security to github CODEOWNER file [#142](#142) ([eternal44](https://github.com/eternal44)) - fix(lib/provider.js): fix RecurlyProvider throwing error when fraud property is set [#123](#123) ([mikeedwards](https://github.com/mikeedwards))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
React18 is providing concurrent feature, to this component specifically, it will need the component to mount and unmount couple times and got the same result, issue is surfaced by strict mode. see more information here,
The current implementation is setting up element events in constructor but destroy it when unmount, so when react18 unmount the component and mount again, element won't get setup again.
Changes