[Scoper] Using different scoper.php for php 7.0 #6295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomasVotruba if this still make php 7.1 fail, then there is something wrong with the git add process itself, as previously, it still works on php 7.1. Let's try. |
samsonasik
commented
May 2, 2021
| @@ -5,7 +5,7 @@ name: Build Scoped Rector PHP 7.0 | |||
| on: | |||
| push: | |||
| branches: | |||
| - main | |||
| - never | |||
There was a problem hiding this comment.
temporary disable scoped 7.0
|
the php 7.1 scoped seems working again. |
|
Thanks 👍 https://github.com/rectorphp/rector-prefixed is passing ✔️ |
TomasVotruba
added a commit
that referenced
this pull request
Sep 8, 2024
rectorphp/rector-src@1ebb7aa [CodeQuality] Allow transform static to self on final class on ConvertStaticPrivateConstantToSelfRector (#6295)
TomasVotruba
added a commit
that referenced
this pull request
Sep 8, 2024
rectorphp/rector-src@1ebb7aa [CodeQuality] Allow transform static to self on final class on ConvertStaticPrivateConstantToSelfRector (#6295)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert original scoper.php