[CodingStyle] Improve unspread array #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
TomasVotruba
commented
Jan 9, 2021
| { | ||
| public function go() | ||
| { | ||
| $this->run('John', [1, 2, 3, 4, 5]); |
There was a problem hiding this comment.
@samsonasik Hey, just FYI, I had to update this rules to group items to an array like this.
It broke some code on Symplify.
TomasVotruba
commented
Jan 9, 2021
| /** | ||
| * @param ClassMethod|MethodCall $node | ||
| */ | ||
| private function isInVendor(Node $node): bool |
There was a problem hiding this comment.
@samsonasik Just a tip for next code. The /vendor check can be done better by using NodeRepository. It contains all the nodes from parsed project. So what is not there, is in vendor :)
TomasVotruba
force-pushed
the
unspread-array
branch
from
93fc000 to
a980f96
Compare
TomasVotruba
added a commit
that referenced
this pull request
Oct 5, 2023
rectorphp/rector-src@6aed089 [Php80] Skip when already implements Stringable and has string return type on StringableForToStringRector (#5120)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.