Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in rector_rules_overview.md #3494

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

berezuev
Copy link
Contributor

@berezuev berezuev commented Jun 8, 2020

Change classname in ReturnThisRemoveRector example.
Looks like it should be the same with config in example above.

@berezuev berezuev changed the title Fix type in rector_rules_overview.md Fix typo in rector_rules_overview.md Jun 8, 2020
@TomasVotruba
Copy link
Member

This file is generated from getRectorDefinition(), so this needs to be updated in the responsible Rector class too

Change classname in ReturnThisRemoveRector example
@berezuev
Copy link
Contributor Author

berezuev commented Jun 8, 2020

Here it is!

@TomasVotruba
Copy link
Member

Thank you 👍

@TomasVotruba TomasVotruba merged commit 6200b97 into rectorphp:master Jun 8, 2020
@berezuev berezuev deleted the patch-1 branch June 9, 2020 07:09
TomasVotruba added a commit that referenced this pull request Mar 20, 2023
rectorphp/rector-src@ea0c6c1 [Core] Refactor AstResolver to locate node with SimpleCallableNodeTraverser (#3494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants