ValueResolver confused by __DIR__ constant

[jtojnar]

Bug Report

Subject	Details
Rector version	2.0.9

I am trying to upgrade a custom Rector rule from old version of Rector in j0k3r/graby#365 but in 2.0, it no longer appears to be able to handle __DIR__ constant.

Minimal PHP Code Causing Issue

https://getrector.com/demo/4c428282-bbc7-46b6-9db4-eab6d9e90f2f

Inserting var_dump (not allowed on the demo server) would show:

array(1) {
  ["bar"]=>
  NULL
}

Expected Behaviour

It should resolve the __DIR__ constant in the context of refactored file:

array(1) {
  ["bar"]=>
  array(1) {
    ["foo"]=> "/home/jtojnar/Projects/graby/tests/bar"
  }
}

[samsonasik]

The feature seems removed at PR:

• Remove CurrentFileProvider from ValueResolver, let type resolver handle dir and filename rector-src#6069

which remove get dir and file due to removal of usage of CurrentFileProvider on ValueResolver by @TomasVotruba

[TomasVotruba]

@samsonasik Could you cover this with test? PHPStan used to cover __DIR__ before.
If that is not the case, we should revert it.

[samsonasik]

sure, I will do

[TomasVotruba]

👍