[TypeDeclaration] Adds AddClosureParamTypeFromArgRector & AddClosureParamTypeFromArgClassStringRector rule

[peterfox]

Changes

• Implements a new AddClosureParamTypeFromArgRector and AddClosureParamTypeFromArgClassStringRector rule.
• Adds the AddClosureParamTypeFromArgRector value object for the rule.
• Adds test and fixtures.
• Improvements to AddParamTypeForFunctionLikeWithinCallLikeArgDeclarationRector

Why

Sometimes you want to apply the type to a FunctionLike Param based on other Args to the parent method, an example in Laravel:

-$app->extend(Foo::class, function ($fooInstance) {
+$app->extend(Foo::class, function (Foo $fooInstance) {
});
-$object->tap('foobar', function ($foobarString) {
+$object->tap('foobar', function (string $fooInstance) {
});

Notes

Now implemented as a single rule that can detect either a class constant string or it can use the type from the argument.

[TomasVotruba]

Suggested change

	if (($node->name ?? null) === null) {
	continue;
	}
	if (! $node->name instanceof Identifier) {
	continue;
	}
	if (! $node->name instanceof Identifier) {
	continue;
	}

I think this has the same result

[peterfox]

This fails PHPStan instead I've done:

if (! ($node->name ?? null) instanceof Identifier) {
    continue;
}

[TomasVotruba]

Support for int is enough here

[peterfox]

Are you sure? If it's an arg it could be a named one and that might cause an issue for some people. It makes little difference to the rule but make rules more compatible with code.

[TomasVotruba]

How useful is this practise? I'd expect type should be filled in any case

[peterfox]

I've solved this by just splitting the rules into two unique ones.

The problem was without a mechanism to seperate the two, Class const would mean sometimes you might want a string for a type, it just seemed messy to not be specific

[TomasVotruba]

Looks good 👍 I've added few notes

[TomasVotruba]

I'm looking into this 👍

[TomasVotruba]

I've rebased and tidy up added few changes to improve type detection in #6258

Added few tips I use to write rules 🚀

Cool addition, thank you Peter 👏