[TypeDeclaration] Introducing ClosureReturnTypeRector to handle closure types separately #6106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eturnTypeRector and replace by single ClosureReturnTypeRector as single rule
…ClosureReturnTypeRector
…ed by ClosureReturnTypeRector
TomasVotruba
changed the title
TomasVotruba
changed the title
samsonasik
reviewed
Jul 3, 2024
TomasVotruba
force-pushed
the
tv-single-closure
branch
from
1c0f52e
to
4281da3
Compare
|
Let's 🚢 it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#8678
At the moment we have single AddArrowFunctionReturnTypeRector to handle these cases. I think it makes sense, as in the wild there is hundreds of methods/functions, but much less callbacks/arrow functions. So it's easier to review these cases without granulation.
This rule
ClosureReturnTypeRectorwill handle all closure cases. It will keepClassMethodandFuction_rules separated and granulated, and easier to add types to closures in a separete Rector run :)