Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle Information now reloads when internet is lost then restored. #277

Merged
merged 11 commits into from
May 9, 2016

Conversation

epicstar
Copy link
Member

@epicstar epicstar commented May 9, 2016

Things done:

  • Add ReactiveNetwork dependency to handle phone connection states
  • add retryWhen to vehicle's interval observable to restart interval when connection is back with the above library
  • showToast now reactive in order to ensure that the toasts are only running in the UI thread

I tried using RxLifeCycle, but it requires the activities and fragments to extend RxAppCompatActivities, etc. This will most likely require a rework of the app; plus, if RxLifeCycle is no longer an active project, when we have to extend new Activities, etc. this will actually become a huge problem. I don't think it is wise to use this for the sake of the project in the long term.

@epicstar
Copy link
Member Author

epicstar commented May 9, 2016

Tested... pretty confident... will make another beta release.

@epicstar
Copy link
Member Author

epicstar commented May 9, 2016

Eventually, we'd probably make the disconnect a dialog with an option to enable data/wifi then have a snackbar for a successful reconnect.

@epicstar epicstar deleted the persistent_busselection branch May 11, 2016 22:11
@epicstar epicstar restored the persistent_busselection branch May 11, 2016 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant