-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: separate pkg-config input file for cmake #271
Conversation
I can confirm this fixes the autotools build. |
I think that #259 should just be reverted -- it breaks both autotools and cmake, despite being intended to fix cmake (without taking other build systems into consideration). |
prefix=@CMAKE_INSTALL_PREFIX@ | ||
exec_prefix="${prefix}" | ||
libdir="${exec_prefix}/lib" | ||
includedir="${prefix}/include" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefix=@CMAKE_INSTALL_PREFIX@ | |
exec_prefix="${prefix}" | |
libdir="${exec_prefix}/lib" | |
includedir="${prefix}/include" | |
prefix=@CMAKE_INSTALL_FULL_PREFIX@ | |
exec_prefix="${prefix}" | |
libdir=@CMAKE_INSTALL_FULL_LIBDIR@ | |
includedir=@CMAKE_INSTALL_FULL_INCLUDEDIR@ |
allows lib and includedir that aren't in prefix like when having multiple package outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So does simply reverting the original broken commit, surely? And that has the advantage of having, all along, been the idiomatic way to do pkg-config as recommended by NixOS people too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@q234rty, @eli-schwartz, @Artturin I'm going to close this PR without merge, since there is better one ( thanks to @Artturin ): #272 many thanks for your feedbacks, investigations, collaboration |
No description provided.