Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: separate pkg-config input file for cmake #271

Closed
wants to merge 1 commit into from
Closed

Conversation

recp
Copy link
Owner

@recp recp commented Dec 17, 2022

No description provided.

@q234rty
Copy link

q234rty commented Dec 17, 2022

I can confirm this fixes the autotools build.

@eli-schwartz
Copy link

eli-schwartz commented Dec 18, 2022

I think that #259 should just be reverted -- it breaks both autotools and cmake, despite being intended to fix cmake (without taking other build systems into consideration).

Comment on lines +1 to +4
prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix="${prefix}"
libdir="${exec_prefix}/lib"
includedir="${prefix}/include"
Copy link
Contributor

@Artturin Artturin Dec 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix="${prefix}"
libdir="${exec_prefix}/lib"
includedir="${prefix}/include"
prefix=@CMAKE_INSTALL_FULL_PREFIX@
exec_prefix="${prefix}"
libdir=@CMAKE_INSTALL_FULL_LIBDIR@
includedir=@CMAKE_INSTALL_FULL_INCLUDEDIR@

allows lib and includedir that aren't in prefix like when having multiple package outputs

Copy link

@eli-schwartz eli-schwartz Dec 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So does simply reverting the original broken commit, surely? And that has the advantage of having, all along, been the idiomatic way to do pkg-config as recommended by NixOS people too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@recp
Copy link
Owner Author

recp commented Dec 19, 2022

@q234rty, @eli-schwartz, @Artturin I'm going to close this PR without merge, since there is better one ( thanks to @Artturin ): #272

many thanks for your feedbacks, investigations, collaboration

@recp recp closed this Dec 19, 2022
@recp recp deleted the cmake-pkgconf branch December 19, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants