Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove run.complete() #1879

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Remove run.complete() #1879

merged 2 commits into from
Feb 16, 2023

Conversation

pradnyeshjoshi
Copy link
Collaborator

Description

Removed explicit call to run.complete as the run status is now system managed. This should resolve the failures in CPU nightly tests.

Related Issues

#1876

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

miguelgfierro and others added 2 commits November 21, 2022 09:42
@miguelgfierro
Merge pull request #1856 from microsoft/staging
d110a10 
Staging to main: fix bugs and improve clarity in AzureML test pipelines
@pradnyeshjoshi
remove run.complete()
59389e3
@pradnyeshjoshi pradnyeshjoshi self-assigned this Feb 16, 2023
miguelgfierro
miguelgfierro approved these changes Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything green!

@miguelgfierro miguelgfierro merged commit 5691507 into staging Feb 16, 2023
@miguelgfierro miguelgfierro deleted the pradjoshi/debug_tests branch February 16, 2023 17:52
@miguelgfierro miguelgfierro mentioned this pull request Feb 16, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

@simonzhaoms simonzhaoms Awaiting requested review from simonzhaoms

Assignees

@pradnyeshjoshi pradnyeshjoshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pradnyeshjoshi @miguelgfierro