Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test readme #1775

Merged
merged 27 commits into from
Jul 11, 2022
Merged

Update test readme #1775

merged 27 commits into from
Jul 11, 2022

Conversation

pradnyeshjoshi
Copy link
Collaborator

Description

  • Added details on how to add a new test to the AzureML pipeline to the test readme.
  • Reorganized test readme.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

tests/README.md Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have just done this PR #1777 to your branch.

One minor thing I noticed. In the file https://github.com/microsoft/recommenders/blob/miguel/test_doc/tests/ci/azureml_tests/test_groups.py we use the word spark in the nightly builds and pyspark in the unit tests, can we choose the same for both?

@pradnyeshjoshi
Copy link
Collaborator Author

Have just done this PR #1777 to your branch.

One minor thing I noticed. In the file https://github.com/microsoft/recommenders/blob/miguel/test_doc/tests/ci/azureml_tests/test_groups.py we use the word spark in the nightly builds and pyspark in the unit tests, can we choose the same for both?

I merged PR #1777 into my branch and changed pyspark to spark.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, I have done a typo review, feel free to review and change if you see more typos.

tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
pradnyeshjoshi and others added 6 commits July 11, 2022 08:08
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
pradnyeshjoshi and others added 8 commits July 11, 2022 08:11
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
@miguelgfierro miguelgfierro merged commit 398a6ec into staging Jul 11, 2022
@miguelgfierro miguelgfierro deleted the pradjoshi/test_doc branch July 11, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants