-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test readme #1775
Update test readme #1775
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have just done this PR #1777 to your branch.
One minor thing I noticed. In the file https://github.com/microsoft/recommenders/blob/miguel/test_doc/tests/ci/azureml_tests/test_groups.py we use the word spark
in the nightly builds and pyspark
in the unit tests, can we choose the same for both?
I merged PR #1777 into my branch and changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good, I have done a typo review, feel free to review and change if you see more typos.
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Co-authored-by: Miguel González-Fierro <[email protected]>
Description
Related Issues
Checklist:
staging branch
and not tomain branch
.