Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify AzureML test workflows #1773

Merged
merged 12 commits into from
Jul 7, 2022
Merged

Conversation

pradnyeshjoshi
Copy link
Collaborator

@pradnyeshjoshi pradnyeshjoshi commented Jul 6, 2022

Description

Nightly CPU/GPU/Spark/Unit test workflows for AzureML test pipeline had a lot of redundant code. Created a template workflow which is then reused inside the nightly CPU/GPU/Spark/Unit test workflows.
Workflow runs: Nightly CPU, GPU, Spark, Unit tests

Related Issues

#1760

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good

@miguelgfierro miguelgfierro requested a review from simonzhaoms July 7, 2022 08:27
@simonzhaoms
Copy link
Collaborator

@pradnyeshjoshi There is a possibility that we can combine azureml_cpu_nightly.yml, azureml_gpu_nightly.yml, azureml_spark_nightly.yml and azureml_unit_test.yml into one single file. Do you think whether it is better?

@miguelgfierro
Copy link
Collaborator

There is a possibility that we can combine azureml_cpu_nightly.yml, azureml_gpu_nightly.yml, azureml_spark_nightly.yml

My understanding was that if we do this, we won't be able to track 3 different badges as we are doing here: https://github.com/microsoft/recommenders/tree/staging#azureml-nightly-build-status

Is this right Pradnyesh?

@pradnyeshjoshi
Copy link
Collaborator Author

There is a possibility that we can combine azureml_cpu_nightly.yml, azureml_gpu_nightly.yml, azureml_spark_nightly.yml

My understanding was that if we do this, we won't be able to track 3 different badges as we are doing here: https://github.com/microsoft/recommenders/tree/staging#azureml-nightly-build-status

Is this right Pradnyesh?

Yes, @simonzhaoms we decided to separate these workflows earlier to have different badges for each.

@pradnyeshjoshi pradnyeshjoshi merged commit f698192 into staging Jul 7, 2022
@pradnyeshjoshi pradnyeshjoshi deleted the pradjoshi/simplify_tests branch July 7, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants