Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov Fix #1665

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Codecov Fix #1665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee469a0
Fix codecov 'No source for code' error
Mar 9, 2022
0fa2ccf
Add the missing 'experimental' test marker
Mar 9, 2022
c99afa7
Merge branch 'staging' into laserprec/code-cov-fix
anargyri Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/actions/merge-cov/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,18 @@ runs:
# different parallelized runs
- name: Merge coverage reports
shell: bash
# NOTE: Merging code reports generated from self-hosted (aml) runners can be problematic
# as reports may reference the source code at an unresolvable absolute path.
# For example, you may encounter errors like:
# "CoverageWarning: Couldn't parse
# '/home/azureuser/runner/work/recommenders/recommenders/recommenders/evaluation/__init__.py':
# No source for code"
# Work-around: Creating a symlink at the root that points to the default local runner folder: '/home/runner/work/recommenders'
run: |
sudo mkdir -p /home/azureuser
sudo ln -s /home/runner /home/azureuser/runner
anargyri marked this conversation as resolved.
Show resolved Hide resolved
python -m coverage combine .coverage*
python -m coverage report
python -m coverage report -i
python -m coverage xml -i

- name: Show merged report
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/pr-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,10 @@ jobs:
# different kinds of tests are located in tests/<unit|integration|smoke> folders
test-kind: ['unit']
# pytest markers configured in tox.ini. See https://docs.pytest.org/en/6.2.x/example/markers.html
test-marker: ['gpu and notebooks and not spark and not experimental', 'gpu and not notebooks and not spark and not experimental']
test-marker: [
'gpu and not notebooks and not spark and not experimental',
'gpu and notebooks and not spark and not experimental'
]

steps:
- uses: actions/checkout@v2
Expand Down
1 change: 1 addition & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ markers =
# See https://docs.pytest.org/en/stable/example/markers.html#registering-markers
deeprec: test deeprec model
sequential: test sequential model
experimental: mark a test that has advanced build requirements or might conflict with libraries from other options
notebooks: mark a test as notebooks test
smoke: mark a test as smoke test
integration: mark a test as integration test
Expand Down