Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drop_duplicates() from SAR method fix #1464 #1588

Merged
merged 10 commits into from
Feb 28, 2022
+17 −9
Merged

Remove drop_duplicates() from SAR method fix #1464 #1588

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6aa7d8d
Remove drop_duplicates() from SAR method fix #1464
miguelgfierro Dec 17, 2021
562d19b
flake is complaining
miguelgfierro Dec 17, 2021
f1d53a7
Merge branch 'staging' into miguelgfierro-patch-2
anargyri Jan 21, 2022
bc76330
Merge branch 'staging' into miguelgfierro-patch-2
simonzhaoms Feb 23, 2022
9f9d497
Typos
simonzhaoms Feb 23, 2022
8392535
Define self.unity_user_affinity inside __init__()
simonzhaoms Feb 23, 2022
0c4d707
Remove drop_duplicates() from SAR method
simonzhaoms Feb 23, 2022
19b8fa3
Remove duplicates in testing data
simonzhaoms Feb 24, 2022
557edcc
Remove duplicates in test data for recommend_k_items
simonzhaoms Feb 24, 2022
eb5294a
Allow duplicates in score data
simonzhaoms Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions recommenders/models/sar/sar_singlenode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,13 @@ def set_index(self, df):
def fit(self, df):
"""Main fit method for SAR.

.. note::

Please make sure that `df` has no duplicates.

Args:
df (pandas.DataFrame): User item rating dataframe
df (pandas.DataFrame): User item rating dataframe (without duplicates).
"""

# generate continuous indices if this hasn't been done
if self.index2item is None:
self.set_index(df)
Expand All @@ -226,12 +229,6 @@ def fit(self, df):
if self.time_decay_flag:
logger.info("Calculating time-decayed affinities")
temp_df = self.compute_time_decay(df=temp_df, decay_column=self.col_rating)
else:
# without time decay use the latest user-item rating in the dataset as the affinity score
logger.info("De-duplicating the user-item counts")
temp_df = temp_df.drop_duplicates(
[self.col_user, self.col_item], keep="last"
)

logger.info("Creating index columns")
# add mapping of user and item ids to indices
Expand Down