Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 Fixes (Part1) #1550

Merged
merged 22 commits into from
Oct 19, 2021
+279 −290
Merged

Flake8 Fixes (Part1) #1550

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b76bac0
Find and ignore all current flake8 issues
Oct 15, 2021
2c0021a
flake8 ignore 'contrib' folder
Oct 15, 2021
c7c4b42
W291 trailing whitespace (fixed)
Oct 15, 2021
45f179b
W292 no newline at end of file (fixed)
Oct 15, 2021
9ded34f
W391 blank line at end of file (fixed)
Oct 15, 2021
c90ad54
W293 blank line contains whitespace (fixed)
Oct 15, 2021
e0c7e28
E303 too many blank lines (fixed)
Oct 15, 2021
5db8103
E262 inline comment should start with '# ' (fixed)
Oct 15, 2021
c549eb4
E266 too many leading '#' for block comment (fixed)
Oct 15, 2021
bc40172
E266 too many leading '#' for block comment (fixed)
Oct 15, 2021
b486907
E501 line too long (244 > 180 characters) (fixed)
Oct 15, 2021
c51ecf9
E302 expected 2 blank lines, found 1 (fixed)
Oct 15, 2021
28ec6fd
E128 continuation line under-indented for visual indent (fixed)
Oct 15, 2021
c81d765
E126 continuation line over-indented for hanging indent (fixed)
Oct 15, 2021
5d5d214
E226 missing whitespace around arithmetic operator (fixed)
Oct 15, 2021
6334876
E401 multiple imports on one line (fixed)
Oct 15, 2021
754325a
E401 multiple imports on one line (fixed)
Oct 15, 2021
4d9c790
F811 redefinition of unused 'X' from line 4 (fixed)
Oct 15, 2021
d94d003
F841 local variable 'a' is assigned to but never used (fixed)
Oct 15, 2021
bd57485
F401 'X' imported but unused (fixed)
Oct 15, 2021
915d1fa
Enable flake8 check in CIs
Oct 19, 2021
6f485c3
Merge latest changes from 'staging' into laserprec/flake8-fix
Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
W292 no newline at end of file (fixed)
Jianjie Liu committed Oct 15, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 45f179b1cf0e1e9b4f08b3df9773d783437470fe
2 changes: 0 additions & 2 deletions recommenders/tuning/nni/nni_utils.py
View file
Original file line number Diff line number Diff line change
@@ -153,5 +153,3 @@ def start_nni(config_path, wait=WAITING_TIME, max_retries=MAX_RETRIES):
if proc.returncode != 0:
raise RuntimeError("'nnictl create' failed with code %d" % proc.returncode)
check_experiment_status(wait=wait, max_retries=max_retries)


2 changes: 1 addition & 1 deletion tox.ini
View file
Original file line number Diff line number Diff line change
@@ -83,7 +83,7 @@ skip_empty = true
ignore =
# Simple style issues (deletion/addition)
; W291 # trailing whitespace (done)
W292 # no newline at end of file
; W292 # no newline at end of file (done)
W503 # line break before binary operator
W391 # blank line at end of file
W293 # blank line contains whitespace