-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docstrings #1446
Merged
Merged
Add docstrings #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* review 📝 in common * wip * deprec * fix 📝 Co-authored-by: miguelgfierro <[email protected]>
* 🐛 in installation process and in test execution * make sure we are using the package when running the test 🐛 * tag * xlearn 🐛 * trying to remove exit -1 * trying to remove exit -1 🐛 * Remove html files in docs from being pushed * trying to remove exit -1 🐛🐛 * trying to remove exit -1 failOnStderr * trying to remove exit -1 💥 * trying to remove exit -1 💥💥 * new full run xlearn in * trigger tag 🐛 * Edit CONTRIBUTING.md * backoff * 📝 * review 📝 in common * wip * deprec * fix 📝 * removing dev branch, will trigger only with tag * Fix docstrings in dataset and evaluation * Fix ** in docstring * Fix code example in docstring * Reorder data sets in rst * fix deeprec tests * remove xlearn from core deps * remove xlearn from core deps 🐛 * Add sections for each data set * improve maybe download tests * Edit dataset utils * wip * Add missing docstrings * Fix list Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Miguel González-Fierro <[email protected]>
* fix base model * lightgcn, dkn * reviewing deeprec * SUM Co-authored-by: miguelgfierro <[email protected]>
* common * common * movielens * cord * mind * 🐛 * downlowd * deeprec * deeprec * 💥 * Update dataset.rst * Update python_utils.py * typo * Update python_utils.py * Update pandas_df_utils.py * Update sparse.py * Update sparse.py Follow PEP8 for variable name Co-authored-by: miguelgfierro <[email protected]> Co-authored-by: Andreas Argyriou <[email protected]> Co-authored-by: YanZhangADS <[email protected]>
miguelgfierro
requested review from
anargyri,
gramhagen,
loomlike,
wutaomsft and
yueguoguo
as code owners
June 15, 2021 08:46
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
anargyri
approved these changes
Jun 15, 2021
@YanZhangADS it looks there is a small error in the unit tests:
this is different to what we fixed in this PR #1447 |
Sorry I changed this. Let me fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
#1441
Checklist:
staging branch
and not tomain branch
.