Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kdd2020 tutorial updated #1208

Merged
merged 33 commits into from
Sep 25, 2020
Merged

Kdd2020 tutorial updated #1208

merged 33 commits into from
Sep 25, 2020

Conversation

Leavingseason
Copy link
Collaborator

@Leavingseason Leavingseason commented Sep 25, 2020 •
edited
Loading

Description

Merge the KDD2020 tutorial into staging branch.

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

Leavingseason and others added 26 commits July 25, 2020 06:56
@Leavingseason
add kdd2020 tutorials for knowledge-aware recommendations
ffbce15
@Leavingseason
v0: ready for running
141eb91
@Leavingseason
add environment config files
184d289
@Leavingseason
text changes
8f37eb8
@Leavingseason
update notebook step1
70f0c47
@Leavingseason
update notebook step2
eacac58
@Leavingseason
update notebook step3
9db5623
@Leavingseason
update notebook steps
a38528d
@yueguoguo
add README
aa6d9d9
@yueguoguo
update readme
1949734
@Leavingseason
Merge pull request #1164 from microsoft/le/kdd_tutorial
6238d41 
add README
@Leavingseason
update notebooks; move functions to utils
171d244
@Leavingseason
update notebook step 3
681239e
@Leavingseason
update step1 and step5
c101ad7
@Leavingseason
fix LightGCN bug and update step2 step5
5918168
@Leavingseason
add reco_gpu_kdd.yaml
d840596
@Leavingseason
delete unused folder; add cpu yaml
d7c0c0e
@Leavingseason
update reco_cpu_kdd.yaml
1b40882
@Leavingseason
update yaml config: remove pytorch and fastai
a2679a6
@Leavingseason
Update README.md
950dfd8 
Update README.md, add conda instruction.
@Leavingseason
add scripts for subgraph analysis
a9aa7ed
@miguelgfierro
Update reco_gpu_kdd.yaml
cc9c645
@Leavingseason
Merge branch 'staging' into kdd2020_tutorial
03d3b19
@Leavingseason
Merge branch 'staging' into kdd2020_tutorial
283a3bd
@Leavingseason
update yaml
e884a69
@Leavingseason
Adjust structure; update comments
d854c39
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

yueguoguo
yueguoguo approved these changes Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@yueguoguo yueguoguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the codes in general look good to me. The only comment is related to the code structure. The initial idea of creating the sub-directory of "scenarios" is to provide business-oriented and/or high-level information to help users ramp-up with recommender algorithms to start with. The actual codes/notebooks will be placed under the other directories like utils, examples, etc., such that, the text in the scenario directories can reference. Regarding this, maybe we want to restructure the codes to comply with this design. What do you think? @Leavingseason @miguelgfierro

scenarios/academic/KDD2020-tutorial/README.md Outdated Show resolved Hide resolved
scenarios/academic/KDD2020-tutorial/reco_cpu_kdd.yaml Outdated Show resolved Hide resolved
scenarios/academic/KDD2020-tutorial/run_transE.sh Outdated Show resolved Hide resolved
miguelgfierro
miguelgfierro reviewed Sep 25, 2020
View reviewed changes
reco_utils/recommender/deeprec/io/dkn_item2item_iterator.py Show resolved Hide resolved
reco_utils/recommender/deeprec/models/dkn_item2item.py Show resolved Hide resolved
scenarios/academic/KDD2020-tutorial/README.md Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@miguelgfierro
Copy link
Collaborator

haha @yueguoguo and I were giving feedback at the same time and independently thought in the same line 哈哈哈哈哈哈哈哈 our minds are synchronize, maybe we have a neuralink XDD

@miguelgfierro miguelgfierro merged commit a798694 into staging Sep 25, 2020
@miguelgfierro miguelgfierro deleted the kdd2020_tutorial_updated branch September 25, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgfierro miguelgfierro miguelgfierro approved these changes

@yueguoguo yueguoguo yueguoguo approved these changes

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@loomlike loomlike Awaiting requested review from loomlike loomlike is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leavingseason @miguelgfierro @yueguoguo