Update module spec yaml and module registration notebook to latest version #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weedqian
requested review from
gramhagen,
miguelgfierro and
yueguoguo
as code owners
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
There was a problem hiding this comment.
Looks good @weedqian, one minor ask. In the rest of the notebooks we always put all the imports together on a cell at the beginning, see this https://github.com/microsoft/recommenders/blob/master/notebooks/00_quick_start/sar_movielens.ipynb, could you please make that change? so we maintain the consistency in all notebooks
dwt0317
reviewed
Apr 2, 2020
| category: Recommenders | ||
| moduleIdentifier: | ||
| namespace: microsoft.com/cat | ||
| moduleName: Splitter Stratified |
There was a problem hiding this comment.
Maybe it should be "Stratified Splitter".
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
AzureML Designer is targeting to let Custom Module go public to both 1st and 3rd customers. We published a new version module spec and provided a CLI tool to register module to workspace.
Module Spec: https://msdata.visualstudio.com/AzureML/_git/ModuleDocs?path=%2Fdocs%2Fdefinition-of-module-spec.md&_a=preview
CLI: https://msdata.visualstudio.com/AzureML/_git/ModuleDocs?path=%2Fdocs%2Fcli%2Fa-quick-go-through.md&_a=preview
Checklist:
stagingand notmaster.