Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker build bug for cmake and xlearn #1034

Merged
merged 5 commits into from
Jan 17, 2020
Merged

Docker build bug for cmake and xlearn #1034

merged 5 commits into from
Jan 17, 2020

Conversation

yueguoguo
Copy link
Collaborator

@yueguoguo yueguoguo commented Jan 15, 2020 •
edited by miguelgfierro
Loading

Description

Fix the issue that Docker build did not install cmake and thus xlearn properly.

Related Issues

#1026

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging and not master.

@yueguoguo
Copy link
Collaborator Author

FYI @gramhagen

@yueguoguo yueguoguo changed the title Le docker Docker build bug for cmake and xlearn Jan 15, 2020
miguelgfierro
miguelgfierro approved these changes Jan 15, 2020
View reviewed changes
Copy link
Collaborator

@miguelgfierro miguelgfierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gramhagen
gramhagen requested changes Jan 15, 2020
View reviewed changes
Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest making cmake version configurable

docker/Dockerfile Outdated Show resolved Hide resolved
gramhagen
gramhagen approved these changes Jan 16, 2020
View reviewed changes
Copy link
Collaborator

@gramhagen gramhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@miguelgfierro miguelgfierro merged commit 31e21c2 into staging Jan 17, 2020
@miguelgfierro miguelgfierro deleted the le_docker branch January 17, 2020 11:01
@yueguoguo yueguoguo mentioned this pull request Jan 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gramhagen gramhagen gramhagen approved these changes

@miguelgfierro miguelgfierro miguelgfierro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yueguoguo @miguelgfierro @gramhagen