Merge pull request #994 from microsoft/miguel/nightly_continue_on_error

force to remove the conda env always in the nightly builds
recommenders-team · Dec 4, 2019 · 63a331d · 63a331d
2 parents 7e6e1bf + 86aa40f
commit 63a331d
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 8 deletions.
diff --git a/tests/ci/azure_pipeline_test/dsvm_nightly_linux_cpu.yml b/tests/ci/azure_pipeline_test/dsvm_nightly_linux_cpu.yml
@@ -54,4 +54,4 @@ jobs:
     workingDirectory: tests
     displayName: 'Conda remove'
     continueOnError: true
-    condition: succeededOrFailed()
+    condition: always() # this step will always run, even if the pipeline is canceled
diff --git a/tests/ci/azure_pipeline_test/dsvm_nightly_linux_gpu.yml b/tests/ci/azure_pipeline_test/dsvm_nightly_linux_gpu.yml
@@ -54,5 +54,5 @@ jobs:
     workingDirectory: tests
     displayName: 'Conda remove'
     continueOnError: true
-    condition: succeededOrFailed()
+    condition: always() # this step will always run, even if the pipeline is canceled
 
diff --git a/tests/ci/azure_pipeline_test/dsvm_nightly_linux_pyspark.yml b/tests/ci/azure_pipeline_test/dsvm_nightly_linux_pyspark.yml
@@ -54,4 +54,4 @@ jobs:
     workingDirectory: tests
     displayName: 'Conda remove'
     continueOnError: true
-    condition: succeededOrFailed()
+    condition: always() # this step will always run, even if the pipeline is canceled
diff --git a/tests/ci/azure_pipeline_test/dsvm_nightly_win_cpu.yml b/tests/ci/azure_pipeline_test/dsvm_nightly_win_cpu.yml
@@ -47,11 +47,11 @@ jobs:
 
   - script: |
       call conda env remove -n nightly_reco_base -y
-      rmdir /s /q C:\Anaconda\envs\nightly_reco_base
+      if exist C:\Anaconda\envs\nightly_reco_base rmdir /s /q C:\Anaconda\envs\nightly_reco_base
     workingDirectory: tests
     displayName: 'Conda remove'
     continueOnError: true
-    condition: succeededOrFailed()
+    condition: always() # this step will always run, even if the pipeline is canceled
 
   - script: |
       del /q /S %LOCALAPPDATA%\Temp\*

diff --git a/tests/ci/azure_pipeline_test/dsvm_nightly_win_gpu.yml b/tests/ci/azure_pipeline_test/dsvm_nightly_win_gpu.yml
@@ -47,7 +47,8 @@ jobs:
 
   - script: |
       call conda env remove -n nightly_reco_gpu -y
-      rmdir /s /q C:\Anaconda\envs\nightly_reco_gpu
+      if exist C:\Anaconda\envs\nightly_reco_gpu rmdir /s /q C:\Anaconda\envs\nightly_reco_gpu
     workingDirectory: tests
     displayName: 'Conda remove'
     continueOnError: true
+    condition: always() # this step will always run, even if the pipeline is canceled
diff --git a/tests/ci/azure_pipeline_test/dsvm_nightly_win_pyspark.yml b/tests/ci/azure_pipeline_test/dsvm_nightly_win_pyspark.yml
@@ -51,9 +51,9 @@ jobs:
 
   - script: |
       call conda env remove -n nightly_reco_pyspark -y
-      rmdir /s /q C:\Anaconda\envs\nightly_reco_pyspark
+      if exist C:\Anaconda\envs\nightly_reco_pyspark rmdir /s /q C:\Anaconda\envs\nightly_reco_pyspark
     workingDirectory: tests
     displayName: 'Conda remove'
     continueOnError: true
-    condition: succeededOrFailed()
+    condition: always() # this step will always run, even if the pipeline is canceled