Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect rg #295

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Protect rg #295

merged 2 commits into from
Mar 27, 2023

Conversation

JeffreyVWT
Copy link
Contributor

@JeffreyVWT JeffreyVWT commented Mar 27, 2023 •
edited
Loading

  • Allow lock for read-only
  • Allow lock for preventing deletion

image

@JeffreyVWT JeffreyVWT requested review from a team and tom-reinders as code owners March 27, 2023 13:26
@tom-reinders
Copy link
Member

Tested the folder locally with terraform validate.

The failing test is going to be ignored in this PR.
The failing test is related to ticket hashicorp/terraform-provider-azurerm#21127 and PR hashicorp/terraform-provider-azurerm#20987 and will be watched if we need to change this or if this is a bug on their end.

@tom-reinders tom-reinders merged commit 857907a into develop Mar 27, 2023
@tom-reinders tom-reinders added this to the v3.0.0 milestone Mar 27, 2023
@tom-reinders tom-reinders deleted the feature/13808-protect-rg branch March 27, 2023 13:52
@tom-reinders tom-reinders mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-reinders tom-reinders tom-reinders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffreyVWT @tom-reinders