Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Upgrading to latest version fails due to missing mock files #955

Closed
hbastosc opened this issue Mar 8, 2023 · 3 comments
Closed

Upgrading to latest version fails due to missing mock files #955

hbastosc opened this issue Mar 8, 2023 · 3 comments

Comments

@hbastosc
Copy link

hbastosc commented Mar 8, 2023

When using aws-nuke as a library, if I try to update to the latest version resources fails because mock files are missing.

 ✗ go mod tidy
go: downloading github.com/golang/mock v1.6.0
go: finding module for package github.com/rebuy-de/aws-nuke/v2/mocks/mock_cloudformationiface
go: downloading github.com/rebuy-de/aws-nuke v2.10.0+incompatible
github.com/McK-Internal/CNT_MCO-sandbox_asset/pkg/aws-nuke/cmd imports
        github.com/rebuy-de/aws-nuke/v2/resources tested by
        github.com/rebuy-de/aws-nuke/v2/resources.test imports
        github.com/rebuy-de/aws-nuke/v2/mocks/mock_cloudformationiface: module github.com/rebuy-de/aws-nuke/v2@latest found (v2.21.2), but does not contain package github.com/rebuy-de/aws-nuke/v2/mocks/mock_cloudformationiface

Seems this is used on some test files and that are inside resources and causing this issue. Is this something that can be moved somewhere else to avoid this error.

@andreadecorte
Copy link
Contributor

Facing the issue too. To fix this, mocks should be committed to the repository. There is no real consensus on it, but the go documentation seems to push towards it for easier usage (see this blog post for some references)

@iuliancristea
Copy link

Hi @svenwltr @der-eismann,

Any ideas here? Could this be addressed? Shouldn't be a big change

@ekristen
Copy link
Contributor

Take a look at the active fork that's now being managed https://github.com/ekristen/aws-nuke

If you have a chance, please check it out and let us know if you run into an issues by opening an issue over on the fork.


Please see the copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information.

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants