Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the aws-nuke fork? #471

Closed
hutchic opened this issue Dec 12, 2023 · 2 comments
Closed

Why the aws-nuke fork? #471

hutchic opened this issue Dec 12, 2023 · 2 comments

Comments

@hutchic
Copy link

hutchic commented Dec 12, 2023

Looking for a similar issue all I found was #312 and when I look at the delta the official aws-nuke more maintained / better supported and so I'm curious why was aws-nuke forked?

I don't doubt there was a reason but I'm not sure I see it anymore which brings me to the second question -- is the fork still necessary? If it is maybe setting up the github pull bot or equivalent to help keep the fork more closely sync'd would be a good approach

@amyschoen
Copy link
Member

This was set up so that the team working on DCE could contribute changes back to AWS Nuke and also start using them before they were officially accepted into the project. I can't say if this is still needed or not.

@bjfish25
Copy link
Contributor

bjfish25 commented Feb 29, 2024

The only reason at the moment is for this Pull request: Optum/aws-nuke#19 for this issue: rebuy-de/aws-nuke#955

In the past it was useful to reference our fork specifically to get the changes before merged into rebuy-de/aws-nuke. Future releases of DCE should hopefully not drift as far away from the original repo

@bjfish25 bjfish25 closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants