Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve printing of modules types with one line inside #2709

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Improve printing of modules types with one line inside #2709

merged 2 commits into from
Apr 17, 2023

Conversation

SanderSpies
Copy link
Contributor

Fixes #2697

@SanderSpies SanderSpies changed the title Improve printing of modules with one line Improve printing of modules types with one line inside Apr 17, 2023
@anmonteiro anmonteiro merged commit 229ffdf into reasonml:master Apr 17, 2023
SanderSpies added a commit to SanderSpies/reason that referenced this pull request Apr 18, 2023
@SanderSpies
Merge branch 'master' into sanderspies/fix_2682
79387e0 
* master: (38 commits)
  chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710)
  Improve printing of modules types with one line inside (reasonml#2709)
  generate opam files with dune (reasonml#2704)
  Fix version on refmt (reasonml#2701)
  Drop the result dependency (reasonml#2703)
  Remove old CI and test.sh (reasonml#2705)
  Migrate tests to cram suite (reasonml#2694)
  Make sure win doesnt break when importing (reasonml#2700)
  Fix top level extensions (reasonml#2693)
  Install before importing deps
  Update package json and install esy normally
  Re-arrange esy install
  Reduce install esy time
  Use master branch instead of main
  Ignore _export from esy
  Rename refmt_test to test
  Add esy-ci and opam-ci
  Remove jbuild-ignore
  chore: update nix flake (reasonml#2692)
  chore(readme): clarify 3.9 is unreleased
  ...
SanderSpies added a commit to SanderSpies/reason that referenced this pull request Apr 18, 2023
@SanderSpies
Merge branch 'master' into sanderspies/fix_2681
14a92a9 
* master: (38 commits)
  chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710)
  Improve printing of modules types with one line inside (reasonml#2709)
  generate opam files with dune (reasonml#2704)
  Fix version on refmt (reasonml#2701)
  Drop the result dependency (reasonml#2703)
  Remove old CI and test.sh (reasonml#2705)
  Migrate tests to cram suite (reasonml#2694)
  Make sure win doesnt break when importing (reasonml#2700)
  Fix top level extensions (reasonml#2693)
  Install before importing deps
  Update package json and install esy normally
  Re-arrange esy install
  Reduce install esy time
  Use master branch instead of main
  Ignore _export from esy
  Rename refmt_test to test
  Add esy-ci and opam-ci
  Remove jbuild-ignore
  chore: update nix flake (reasonml#2692)
  chore(readme): clarify 3.9 is unreleased
  ...
davesnx added a commit that referenced this pull request Apr 25, 2023
@davesnx
Merge branch 'master' of github.com:/reasonml/reason
da042bc 
* 'master' of github.com:/reasonml/reason:
  chore: port to ppxlib (#2711)
  fix: binary parser (#2713)
  Improve functor printing. (#2683)
  chore: remove old BS_NO_COMPILER_PATCH flag (#2710)
  Improve printing of modules types with one line inside (#2709)
  generate opam files with dune (#2704)
SanderSpies added a commit to SanderSpies/reason that referenced this pull request May 4, 2023
@SanderSpies
Merge branch 'master' into sanderspies/pprint
8a113c9 
* master:
  fix: binary parser (reasonml#2713)
  Improve functor printing. (reasonml#2683)
  chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710)
  Improve printing of modules types with one line inside (reasonml#2709)
  generate opam files with dune (reasonml#2704)
  Fix version on refmt (reasonml#2701)
  Drop the result dependency (reasonml#2703)
  Remove old CI and test.sh (reasonml#2705)
  Migrate tests to cram suite (reasonml#2694)
  Make sure win doesnt break when importing (reasonml#2700)
  Fix top level extensions (reasonml#2693)
  Install before importing deps
  Update package json and install esy normally
  Re-arrange esy install
  Reduce install esy time
  Use master branch instead of main
  Ignore _export from esy
  Rename refmt_test to test
  Add esy-ci and opam-ci
  Remove jbuild-ignore
@anmonteiro anmonteiro mentioned this pull request Jun 17, 2023
Closed
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Jun 17, 2023
@anmonteiro
[new release] rtop and reason (3.9.0)
7c1c414 
CHANGES:

- Reduce the amount of parentheses around functor usage (@SanderSpies, [reasonml/reason#2683](reasonml/reason#2683))
- Print module type body on separate line (@SanderSpies, [reasonml/reason#2709](reasonml/reason#2709))
- Fix missing patterns around contraint pattern (a pattern with a type annotation).
- Fix top level extension printing
- Remove the dependency on the `result` package, which isn't needed for OCaml
  4.03 and above (@anmonteiro) [reasonml/reason#2703](reasonml/reason#2703)
- Fix the binary parser by converting to the internal AST version used by
  Reason (@anmonteiro) [reasonml/reason#2713](reasonml/reason#2713)
- Port Reason to `ppxlib` (@anmonteiro, [reasonml/reason#2711](reasonml/reason#2711))
- Support OCaml 5.1 (@anmonteiro, [reasonml/reason#2714](reasonml/reason#2714))
@anmonteiro anmonteiro mentioned this pull request Jun 18, 2023
Merged
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Jun 18, 2023
@anmonteiro
[new release] rtop and reason (3.9.0)
f094160 
CHANGES:

- Reduce the amount of parentheses around functor usage (@SanderSpies, [reasonml/reason#2683](reasonml/reason#2683))
- Print module type body on separate line (@SanderSpies, [reasonml/reason#2709](reasonml/reason#2709))
- Fix missing patterns around contraint pattern (a pattern with a type annotation).
- Fix top level extension printing
- Remove the dependency on the `result` package, which isn't needed for OCaml
  4.03 and above (@anmonteiro) [reasonml/reason#2703](reasonml/reason#2703)
- Fix the binary parser by converting to the internal AST version used by
  Reason (@anmonteiro) [reasonml/reason#2713](reasonml/reason#2713)
- Port Reason to `ppxlib` (@anmonteiro, [reasonml/reason#2711](reasonml/reason#2711))
- Support OCaml 5.1 (@anmonteiro, [reasonml/reason#2714](reasonml/reason#2714))
@anmonteiro anmonteiro mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro anmonteiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module types with one line and attribute prints in one line instead of two
2 participants
@SanderSpies @anmonteiro