Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: refmt3 with unary -. in labelled arguments #1642

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Fix: refmt3 with unary -. in labelled arguments #1642

merged 1 commit into from
Nov 15, 2017

Conversation

anmonteiro
Copy link
Member

fixes #1580

@chenglou
Copy link
Member

cc @IwanKaramazow @jordwalke

@jordwalke
Copy link
Member

jordwalke commented Nov 15, 2017 •
edited
Loading

Great fix! Thank you.
(Iwan, let us know if anything looks off and we can fix)

@jordwalke jordwalke merged commit 985f281 into reasonml:master Nov 15, 2017
chenglou added a commit that referenced this pull request Nov 15, 2017
@chenglou
Document #1642
32a9b8d
chenglou added a commit that referenced this pull request Nov 15, 2017
@chenglou
[Docs] #1642
04cd0d6
@anmonteiro anmonteiro deleted the gh-1580 branch November 15, 2017 18:56
@IwanKaramazow
Copy link
Contributor

Looks good, nice job!
There might be another trick to solve this without modifying the parser:
set_lexeme_length

If you add a rule:

| "=-"  {
  set_lexeme_length lexbuf 1;
  EQUAL
}

This trick lets you implement look-ahead: you match a longer string which is not completely consumed. The lexer will resume lexing at "-" and should return MINUS or whatever token is matched in combination with MINUS.

anmonteiro added a commit to anmonteiro/reason that referenced this pull request May 20, 2018
@anmonteiro
Fix syntax error when parsing let x=-.1; and co.
6b8e166 
This is a follow-up to reasonml#1642 employing the strategy highlighted in the following
comment: reasonml#1642 (comment)

It removes the special case around `LABEL_WITH_EQUAL`, making other valid inputs
parseable too.
@anmonteiro anmonteiro mentioned this pull request May 20, 2018
Merged
anmonteiro added a commit to anmonteiro/reason that referenced this pull request May 28, 2018
@anmonteiro
Fix syntax error when parsing let x=-.1; and co.
02200da 
This is a follow-up to reasonml#1642 employing the strategy highlighted in the following
comment: reasonml#1642 (comment)

It removes the special case around `LABEL_WITH_EQUAL`, making other valid inputs
parseable too.
anmonteiro added a commit to anmonteiro/reason that referenced this pull request May 30, 2018
@anmonteiro
Fix syntax error when parsing let x=-.1; and co.
d91b59b 
This is a follow-up to reasonml#1642 employing the strategy highlighted in the following
comment: reasonml#1642 (comment)

It removes the special case around `LABEL_WITH_EQUAL`, making other valid inputs
parseable too.
chenglou pushed a commit that referenced this pull request May 30, 2018
@anmonteiro @chenglou
Fix error when parsing let x=-.1; and co. (#1945)
95f027d 
* Fix syntax error when parsing `let x=-.1;` and co.

This is a follow-up to #1642 employing the strategy highlighted in the following
comment: #1642 (comment)

It removes the special case around `LABEL_WITH_EQUAL`, making other valid inputs
parseable too.

* Fix infix operators that start with equals sign (e.g. `=+`)

also add regression tests for these cases

* check in generated error messages
@jordwalke jordwalke mentioned this pull request Sep 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refmt3 with unary -. in labelled arguments
5 participants
@anmonteiro @chenglou @jordwalke @IwanKaramazow @facebook-github-bot