Deprecate UIDENT Ptyp_package syntax for now

reasonml · Jun 2, 2018 · d1698da · d1698da
1 parent ae61ef5
commit d1698da
Show file tree

Hide file tree

Showing 4 changed files with 3,331 additions and 3,466 deletions.
diff --git a/formatTest/unit_tests/expected_output/firstClassModules.re b/formatTest/unit_tests/expected_output/firstClassModules.re
@@ -10,10 +10,6 @@ module Modifier = (
   val Db.Hashtbl.create():
     Db.Sig with type t = Mods.t
 );
-module Modifier = (
-  val Db.Hashtbl.create():
-    Db.Sig with type t = Mods.t
-);
 module Modifier = (val Db.Hashtbl.create());
 module Modifier = (
   val Db.Hashtbl.create():
@@ -38,11 +34,7 @@ module T = (
 
 module Three = (val three: X_int);
 
-/* Uppercase identifier makes it clear that this is a package type */
 let thing: module Thing = (module MyModule);
-let thing: module Thing = (module MyModule);
-let thing: module Foo.Bar.Thing =
-  (module MyModule);
 let thing: module Foo.Bar.Thing =
   (module MyModule);
 

diff --git a/formatTest/unit_tests/input/firstClassModules.re b/formatTest/unit_tests/input/firstClassModules.re
@@ -1,5 +1,4 @@
 module Modifier = (val ((Db.Hashtbl.create ()): (module Db.Sig with type t = Mods.t)));
-module Modifier = (val (Db.Hashtbl.create (): Db.Sig with type t = Mods.t));
 module Modifier = (val (Db.Hashtbl.create ()): (Db.Sig with type t = Mods.t));
 module Modifier = (val Db.Hashtbl.create (): Db.Sig with type t = Mods.t);
 module Modifier = (val Db.Hashtbl.create ());
@@ -15,10 +14,7 @@ module T = (val (module FirstClass): myLowercaseModule);
 
 module Three = (val three: X_int);
 
-/* Uppercase identifier makes it clear that this is a package type */
-let thing: Thing = (module MyModule);
 let thing: module Thing = (module MyModule);
-let thing: Foo.Bar.Thing = (module MyModule);
 let thing: module Foo.Bar.Thing = (module MyModule);
 
 let smallThing: (module lowercase) = (module Mod);