Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #830 Update tag link component and option font size #928

Merged
merged 2 commits into from
Apr 16, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,19 @@ export const options: SelectOption[] = [
{
value: 'Property',
label: 'Property',
description: `The type of Property will be given to an application that can be launched for a
specific property from Agency Cloud. `,
description: 'launched for a specific property from Agency Cloud. ',
link: 'https://foundations-documentation.reapit.cloud/api/desktop-api#property-1',
},
{
value: 'Applicant',
label: 'Applicant',
description: `The type of Applicant will be given to an application that can be launched for a
specific applicant from Agency Cloud.`,
description: 'launched for a specific applicant from Agency Cloud.',
link: 'https://foundations-documentation.reapit.cloud/api/desktop-api#applicant',
},
{
value: 'idCheck',
label: 'Id Check',
description: `The type of ID Check will be given to an application that can be used to replace
the ID Check screen in Agency Cloud.`,
description: 'Replace the ID Check screen in Agency Cloud.',
link: 'https://foundations-documentation.reapit.cloud/api/desktop-api#id-check',
},
]
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,22 @@ exports[`CustomTag should match a snapshot 1`] = `
>
The type of Property will be given to an application that can be launched for a
specific property from Agency Cloud.
<a
href="https://foundations-documentation.reapit.cloud/api/desktop-api#property-1"
>
More Info
</a>
<span>
For more information on
<b>
Property
</b>
, please

<a
className="reapit-tooltip-link"
href="https://foundations-documentation.reapit.cloud/api/desktop-api#property-1"
rel="noopener noreferrer"
target="_blank"
>
click here
</a>
</span>
</span>
}
placement="bottomLeft"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@ export const CustomTag: React.FC<CustomTagProps> = ({ label, description, link,
overlay={
<span className="reapit-tooltip-content">
{description}
{link && <a href={link}>More Info</a>}
{link && (
<span>
For more information on <b>{label}</b>, please{' '}
<a className="reapit-tooltip-link" href={link} rel="noopener noreferrer" target="_blank">
click here
</a>
</span>
)}
</span>
}
>
Expand Down
4 changes: 3 additions & 1 deletion packages/elements/src/styles/components/dropdown-select.scss
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@

.rc-select-item-option {
position: relative;
font-size: 14px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should use rem instead px

}

.rc-select-item-option-grouped {
Expand Down Expand Up @@ -356,10 +357,11 @@
color: white;
}

.reapit-tooltip-content > a {
.reapit-tooltip-content a {
text-decoration: underline;
margin-left: 2px;
color: white;
font-weight: 700;
}

@keyframes rcSelectDropdownSlideUpIn {
Expand Down