Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #8947 yarn 3 workspaces #8961

Merged
merged 7 commits into from
Apr 28, 2023
Merged

fix: #8947 yarn 3 workspaces #8961

merged 7 commits into from
Apr 28, 2023

Conversation

bashleigh
Copy link
Contributor

Pull request checklist

Detail as per issue below (required):

fixes: #8947

github-actions[bot]
github-actions bot reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this pull request since the title does not match ^(?:(?:[WIP] ?)?(?:build|ci|chore|docs|task|feat|fix|perf|refactor|revert|style|test):(?:\ +?#\d+?\ +?)?.)|(?:[Snyk].) pattern. Please fix the title and re-open the pull request.

@github-actions github-actions bot closed this Apr 28, 2023
@bashleigh bashleigh changed the title Fix: #8947 yarn 3 workspaces fix: #8947 yarn 3 workspaces Apr 28, 2023
@bashleigh bashleigh reopened this Apr 28, 2023
willmcvay
willmcvay reviewed Apr 28, 2023
View reviewed changes
packages/deployment-service/src/codebuild/codebuild-executor-workflow.ts Outdated
@@ -125,6 +125,19 @@ export class CodebuildExecutorWorkflow extends AbstractWorkflow<{
}) {
const params = await this.parameterProvider.obtainParameters(pipeline.id as string)

const setupCommands = [
'n install 14',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use Node 18 please? See my prev on tech debt and Node EOL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

willmcvay
willmcvay reviewed Apr 28, 2023
View reviewed changes
packages/deployment-service/src/codebuild/codebuild-executor-workflow.ts Outdated
@@ -138,12 +151,7 @@ export class CodebuildExecutorWorkflow extends AbstractWorkflow<{
nodejs: 12,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also Node 12 here!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bashleigh bashleigh marked this pull request as ready for review April 28, 2023 11:54
@bashleigh bashleigh merged commit 1b5a83d into master Apr 28, 2023
@bashleigh bashleigh deleted the fix/#8947-yarn-3-workspaces branch April 28, 2023 12:34
@willmcvay willmcvay mentioned this pull request Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@willmcvay willmcvay willmcvay approved these changes

Assignees
No one assigned
Labels
dependencies deployment-service developer-portal foundations-ts-definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Couldn't use the yarn 3 workspace in the IaaS
2 participants
@bashleigh @willmcvay