Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: map slider #891

Merged
merged 2 commits into from
Apr 14, 2020
Merged

feat: map slider #891

merged 2 commits into from
Apr 14, 2020

Conversation

willmcvay
Copy link
Contributor

Fixes: #811

duong-se
duong-se reviewed Apr 14, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vuhuucuong
vuhuucuong approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@willmcvay willmcvay merged commit 72144c0 into master Apr 14, 2020
@willmcvay willmcvay deleted the feat/map-slider branch April 14, 2020 08:03
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
@willmcvay
feat: map slider (#891)
d22c9b9 
* feat: wip

* feat: google maps slider complete
@willmcvay willmcvay mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@duong-se duong-se duong-se approved these changes

@leXuanNha leXuanNha Awaiting requested review from leXuanNha

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

Assignees

@willmcvay willmcvay

Labels
web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Search Widget map component should slide in and out
3 participants
@willmcvay @duong-se @vuhuucuong